Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Debug Session still proceeds after cancelling build task #1001

Closed
award999 opened this issue Aug 8, 2024 · 3 comments
Closed

Test Debug Session still proceeds after cancelling build task #1001

award999 opened this issue Aug 8, 2024 · 3 comments
Assignees
@matthewbastien
Labels
bug Something isn't working

Comments

@award999
Copy link
Contributor

award999 commented Aug 8, 2024

Describe the bug
When you cancel the build task that precedes a debug session for a test, the debug session still starts and LLDB can show fatal errors

To Reproduce
Steps to reproduce the behavior:

  1. I had cleared .build
  2. Started debug session for a test
  3. Pressed ctrl+c in the task terminal to cancel the build all task when I realized I forgot to save a file
  4. Build task is cancelled, but debug session still starts
  5. The call stack frame showed a fatal error

Expected behavior
Check the exit code, if non-zero then don't proceed?

Environment

  • OS: macOS
  • Swift version (output of swift --version): 6.0
  • Visual Studio Code version: 1.92
  • vscode-swift version: 1.10.7

Additional context
N/A
@award999 award999 added the bug Something isn't working label Aug 8, 2024
@award999
Copy link
Contributor Author

award999 commented Aug 8, 2024

What you think @plemarquand?

plemarquand added a commit to plemarquand/vscode-swift that referenced this issue Aug 8, 2024
@plemarquand
Forward signal as exit code
66465ae 
If the user hits ctrl+c during a task we want to treat that as an
unsuccessful process execution and stop proceeding.

Forward the signal and ignore the exit code of a signal is present on
process exit.

Issue: swiftlang#1001
@plemarquand plemarquand mentioned this issue Aug 8, 2024
Merged
plemarquand added a commit that referenced this issue Aug 9, 2024
@plemarquand
Forward signal as exit code (#1006)
52f039e 
If the user hits ctrl+c during a task we want to treat that as an
unsuccessful process execution and stop proceeding.

Forward the signal and ignore the exit code of a signal is present on
process exit.

Issue: #1001
@plemarquand
Copy link
Contributor

Fixed in #1006

@plemarquand plemarquand added the needs verification Issue has been fixed, but requires verification before closing label Aug 9, 2024
@matthewbastien
Copy link
Member

Verified with e0a0fba

@matthewbastien matthewbastien removed the needs verification Issue has been fixed, but requires verification before closing label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewbastien matthewbastien

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plemarquand @matthewbastien @award999