-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser serialized diagnostic file instead of scraping diagnostics from the build log #670
Comments
When did this go in? I know it was being planned but didn't know what state it was in. |
What do you mean by “this“? AFAIK the Swift compiler has been able to emit serialized diagnostic files for quite a while, possibly forever. |
Ok I didn't know about it. |
Oh, interesting. I would have expected that other languages also used serialized diagnostics to produce structured diagnostics. |
This relates to #750 and the coordination between diagnostics that come from parsing the output of a task and the diagnostics that come out of source kit lsp. |
happy to grab this one |
Instead of scraping the build log for errors/warnings/notes using a regex, it would be cleaner if the VS Code extension would read the diagnostic file emitted by
-serialize-diagnostics-path
. That way VS Code could also show notes that are attached to errors as their children, instead of displaying them as a top level problem.The text was updated successfully, but these errors were encountered: