Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we release an Ivy version to npm based on tag 9.1.0? #243

Open
kamechb opened this issue May 17, 2023 · 6 comments
Open

Could we release an Ivy version to npm based on tag 9.1.0? #243

kamechb opened this issue May 17, 2023 · 6 comments

Comments

@kamechb
Copy link

kamechb commented May 17, 2023

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Sorry, we will not be able to answer every support request.  Please consider other venues for support requests

Current behavior
The latest version in NPM is 9.0.0 which was published 2 years ago. And that's a build for view engine.

Expected behavior
Since angular 16 removes the view engine support completely, could we release a package for ivy to support angular 16?

Reproduction of the problem

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • ngx-dnd version: x.x.x
  • Angular version: 2.x.x
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@kamechb kamechb changed the title Could we build a new release for tag 9.1.0 to npm? Could we release an Ivy version to npm based on tag 9.1.0? May 17, 2023
@eighties8
Copy link

Is there an update on this request? My app cannot be compiled as of Angular 16 with latest 9.0 release of the library

@Delagen
Copy link

Delagen commented Feb 2, 2024

I simply copied Typescript source to subfolder of project, write alias in tsconfig.json, and seems all ok. I tired to wait new version of library and may be replace it in future

@eighties8
Copy link

eighties8 commented Feb 6, 2024

@Delagen can you summarize your workaround in a way that it can be reproduced?

I was about to try the fork created by user henrikmiszoglad:
https://github.com/henrikmiszoglad/ngx-dnd-ivy

@Delagen
Copy link

Delagen commented Feb 6, 2024

@Delagen can you summarize your workaround in a way that it can be reproduced?

I was about to try the fork created by user henrikmiszoglad:
https://github.com/henrikmiszoglad/ngx-dnd-ivy

I don't want to try simply fork, project is small, and I simply use as source in my project with simple tsconfig paths alias. I prefer to wait till it will be maintained project.

@eighties8
Copy link

eighties8 commented Feb 8, 2024

I don't want to try simply fork, project is small, and I simply use as source in my project with simple tsconfig paths alias. I prefer to wait till it will be maintained project.

@Delagen, really appreciate your help. I'm still stuck on this.

How are you using ngx-dnd library in your project? I'm using it as a dependency of my project which itself is an angular libary. I've copied the src into my library, but I'm having lots of compiler errors when trying to build.

I've added the paths to my compilerOptions.paths and references to "@swimlane/ngx-dnd" within my libraries do appear to be referencing the local copy and no longer reference node_modules, however, the reference to @swimlane/dragula is throwing error. Do you see same?

This module can only be referenced with ECMAScript imports/exports by turning on the 'allowSyntheticDefaultImports' flag and referencing its default export.ts(2497)
Screenshot 2024-02-08 at 3 04 22 PM

@Delagen
Copy link

Delagen commented Feb 9, 2024

I don't want to try simply fork, project is small, and I simply use as source in my project with simple tsconfig paths alias. I prefer to wait till it will be maintained project.

@Delagen, really appreciate your help. I'm still stuck on this.

How are you using ngx-dnd library in your project? I'm using it as a dependency of my project which itself is an angular libary. I've copied the src into my library, but I'm having lots of compiler errors when trying to build.

I've added the paths to my compilerOptions.paths and references to "@swimlane/ngx-dnd" within my libraries do appear to be referencing the local copy and no longer reference node_modules, however, the reference to @swimlane/dragula is throwing error. Do you see same?

This module can only be referenced with ECMAScript imports/exports by turning on the 'allowSyntheticDefaultImports' flag and referencing its default export.ts(2497)
Screenshot 2024-02-08 at 3 04 22 PM

enable this flag in compilerOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants