Merge pull request #20 from swisnl/fix-empty-attributes

Do not add attributes to item when empty

Author: JaZo

src/Items/JenssegersItem.php

@@ -60,12 +60,14 @@ public function toJsonApiArray(): array
             $data['id'] = $this->getId();
         }
 
-        if (!empty($this->getAttributes())) {
-            $data['attributes'] = $this->toArray();
+        $attributes = $this->toArray();
+        if (!empty($attributes)) {
+            $data['attributes'] = $attributes;
         }
 
-        if (!empty($this->getRelationships())) {
-            $data['relationships'] = $this->getRelationships();
+        $relationships = $this->getRelationships();
+        if (!empty($relationships)) {
+            $data['relationships'] = $relationships;
         }
 
         return $data;

tests/Items/JenssegersItemTest.php

@@ -5,6 +5,7 @@
 use Swis\JsonApi\Client\Items\JenssegersItem;
 use Swis\JsonApi\Client\Tests\AbstractTest;
 use Swis\JsonApi\Client\Tests\Mocks\Items\Jenssegers\WithGetMutatorJenssegersItem;
+use Swis\JsonApi\Client\Tests\Mocks\Items\Jenssegers\WithHiddenJenssegersItem;
 
 class JenssegersItemTest extends AbstractTest
 {
@@ -151,4 +152,22 @@ public function it_adds_unknown_relationships_in_snake_case()
 
         $this->assertTrue($item->hasRelationship('some_relation'));
     }
+
+    /**
+     * @test
+     */
+    public function is_does_not_show_attributes_in_to_json_api_array_when_it_has_no_attributes()
+    {
+        $item = new WithHiddenJenssegersItem($this->attributes);
+        $item->setType('testType');
+        $item->setId(1234);
+
+        $this->assertEquals(
+            [
+                'type' => 'testType',
+                'id'   => 1234,
+            ],
+            $item->toJsonApiArray()
+        );
+    }
 }

tests/_mocks/Items/Jenssegers/WithHiddenJenssegersItem.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Swis\JsonApi\Client\Tests\Mocks\Items\Jenssegers;
+
+use Swis\JsonApi\Client\Items\JenssegersItem;
+
+class WithHiddenJenssegersItem extends JenssegersItem
+{
+    protected $hidden = [
+        'testKey',
+    ];
+}