-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate pet-mode and remove other venv management packages #16867
base: develop
Are you sure you want to change the base?
Conversation
and fix a bunch of broken references
@sunlin7 @RaghuNaik @fnussbaum @bcc32 care to review? |
My site definitely uses pyvenv directly (we have both Spacemacs and non-Spacemacs users), so I would be sad to see this suddenly removed without a good migration path. Is pet-mode a drop-in replacement? Can it be programmatically configured? |
@smile13241324 Thanks for the PR, I test it on my local and some feedback here:
|
Looks like this is not ready to be merged. @sunlin7 thanks for testing, I will fix the setup and will have a look at the pet package to fix the bugs you have found. I'll put this branch to draft state until it is in a better state. |
@smile13241324 thanks for taking a look at this. For context, my site uses pyvenv with a default, hard-coded environment for most users (distributed via NFS or similar), and also some users require the ability to manually set the environment to something specific depending on their team or deployment environment (however, we use a monorepo and therefore having the virtualenv path for all parts of the tree be determined by a single file in the project would not be viable). I took a brief look at pet-mode and it seems it might be able to support this, but maybe not in an especially obvious way (it seems designed to be zero-configuration and doesn't have any interactive commands to support changing the virtual environment). I will consult with some users when I'm back at work on Monday. I am hopeful this will not be a problem, and in the "worst case" we can obviously just still use the |
This PR tries to integrate pet-mode to detect and setup python virtual environments.
I have tried to remove alternative venv management packages as well. However I am unsure if this has broken someones setup, so some testing is in order :).
Should fix #16855 and #16841.