feature #333 New Command! make:registration-form (weaverryan)

This PR was squashed before being merged into the 1.0-dev branch (closes #333).

Discussion
----------

New Command! make:registration-form

New command time! `make:registration-form`. It:

* Generates a completely functional controller, template & form class for registration
* Is capable of detecting or asking for the exact fields you need (e.g. email & password)
* When using Guard, you can generate code to automatically authenticate after registration.

This is one of the last steps to getting an entire authentication system in minutes without needing FOSUserBundle (`make:user`, `make:auth`, `make:registration-form`).

Feedback warmly welcomed.

Cheers!

### Example of generated code:

<details><summary>RegistrationFormType</summary>
<p>

```php
<?php

namespace App\Form;

use App\Entity\User;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\PasswordType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\Validator\Constraints\NotBlank;
use Symfony\Component\Validator\Constraints\Length;

class RegistrationFormType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('email')
            ->add('plainPassword', PasswordType::class, [
                // instead of being set onto the object directly,
                // this is read and encoded in the controller
                'mapped' => false,
                'constraints' => [
                    new NotBlank([
                        'message' => 'Please enter a password',
                    ]),
                    new Length([
                        'min' => 6,
                        'minMessage' => 'Your password should be at least {{ limit }} characters',
                    ]),
                ],            ])
        ;
    }

    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults([
            'data_class' => User::class,
        ]);
    }
}
```

</p>
</details>

<details><summary>RegistrationController</summary>
<p>

```php
namespace App\Controller;

use App\Entity\User;
use App\Form\RegistrationFormType;
use App\Security\StubAuthenticator;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
use Symfony\Component\Security\Guard\GuardAuthenticatorHandler;

class RegistrationController extends AbstractController
{
    /**
     * @route("/register", name="app_register")
     */
    public function register(Request $request, UserPasswordEncoderInterface $passwordEncoder, GuardAuthenticatorHandler $guardHandler, StubAuthenticator $authenticator): Response
    {
        $form = $this->createForm(RegistrationFormType::class);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            /** @var User */
            $user = $form->getData();

            // encode the plain password
            $user->setPassword(
                $passwordEncoder->encodePassword(
                    $user,
                    $form->get('plainPassword')->getData()
                )
            );

            $entityManager = $this->getDoctrine()->getManager();
            $entityManager->persist($user);
            $entityManager->flush();

            // do anything else you need here, like send an email

            return $guardHandler->authenticateUserAndHandleSuccess(
                $user,
                $request,
                $authenticator,
                'main' // firewall name in security.yaml
            );
        }

        return $this->render('registration/register.html.twig', [
            'registrationForm' => $form->createView(),
        ]);
    }
}
```

</p>
</details>

<details><summary>registration/register.html.twig</summary>
<p>

```twig
{% extends 'base.html.twig' %}

{% block title %}Register{% endblock %}

{% block body %}
    <h1>Register</h1>

    {{ form_start(registrationForm) }}
        {{ form_row(registrationForm.email) }}
        {{ form_row(registrationForm.plainPassword) }}

        <button class="btn">Register</button>
    {{ form_end(registrationForm) }}
{% endblock %}
```

</p>
</details>

Commits
-------

f3f4901 making test 3.4-compat
8f46cc2 Asking to add UniqueEntity during make:registration-form
a018245 Adding plainPassword validation and a few other things
16d3b9b Making the make:registration-form work without authenticating
14ade82 Adding the initial version of make:registration-form 🎉
b7699a1 Refactoring form rendering into a service

Author: weaverryan

src/Doctrine/EntityDetails.php

@@ -68,6 +68,11 @@ public function getFormFields()
             }
         }
 
-        return $fields;
+        $fieldsWithTypes = [];
+        foreach ($fields as $field) {
+            $fieldsWithTypes[$field] = null;
+        }
+
+        return $fieldsWithTypes;
     }
 }

src/Maker/MakeCrud.php

@@ -19,6 +19,7 @@
 use Symfony\Bundle\MakerBundle\Doctrine\DoctrineHelper;
 use Symfony\Bundle\MakerBundle\Generator;
 use Symfony\Bundle\MakerBundle\InputConfiguration;
+use Symfony\Bundle\MakerBundle\Renderer\FormTypeRenderer;
 use Symfony\Bundle\MakerBundle\Str;
 use Symfony\Bundle\MakerBundle\Validator;
 use Symfony\Bundle\TwigBundle\TwigBundle;
@@ -38,9 +39,12 @@ final class MakeCrud extends AbstractMaker
 {
     private $doctrineHelper;
 
-    public function __construct(DoctrineHelper $doctrineHelper)
+    private $formTypeRenderer;
+
+    public function __construct(DoctrineHelper $doctrineHelper, FormTypeRenderer $formTypeRenderer)
     {
         $this->doctrineHelper = $doctrineHelper;
+        $this->formTypeRenderer = $formTypeRenderer;
     }
 
     public static function getCommandName(): string
@@ -149,14 +153,10 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             )
         );
 
-        $generator->generateClass(
-            $formClassDetails->getFullName(),
-            'form/Type.tpl.php',
-            [
-                'bounded_full_class_name' => $entityClassDetails->getFullName(),
-                'bounded_class_name' => $entityClassDetails->getShortName(),
-                'form_fields' => $entityDoctrineDetails->getFormFields(),
-            ]
+        $this->formTypeRenderer->render(
+            $formClassDetails,
+            $entityDoctrineDetails->getFormFields(),
+            $entityClassDetails
         );
 
         $templates = [

src/Maker/MakeEntity.php

@@ -26,6 +26,7 @@
 use Symfony\Bundle\MakerBundle\Str;
 use Symfony\Bundle\MakerBundle\Doctrine\EntityRegenerator;
 use Symfony\Bundle\MakerBundle\FileManager;
+use Symfony\Bundle\MakerBundle\Util\ClassDetails;
 use Symfony\Bundle\MakerBundle\Util\ClassSourceManipulator;
 use Symfony\Bundle\MakerBundle\Doctrine\EntityRelation;
 use Symfony\Bundle\MakerBundle\Validator;
@@ -774,7 +775,9 @@ private function createClassManipulator(string $path, ConsoleStyle $io, bool $ov
 
     private function getPathOfClass(string $class): string
     {
-        return (new \ReflectionClass($class))->getFileName();
+        $classDetails = new ClassDetails($class);
+
+        return $classDetails->getPath();
     }
 
     private function isClassInVendor(string $class): bool

src/Maker/MakeForm.php

@@ -17,6 +17,7 @@
 use Symfony\Bundle\MakerBundle\Doctrine\DoctrineHelper;
 use Symfony\Bundle\MakerBundle\Generator;
 use Symfony\Bundle\MakerBundle\InputConfiguration;
+use Symfony\Bundle\MakerBundle\Renderer\FormTypeRenderer;
 use Symfony\Bundle\MakerBundle\Str;
 use Symfony\Bundle\MakerBundle\Util\ClassDetails;
 use Symfony\Bundle\MakerBundle\Validator;
@@ -34,10 +35,12 @@
 final class MakeForm extends AbstractMaker
 {
     private $entityHelper;
+    private $formTypeRenderer;
 
-    public function __construct(DoctrineHelper $entityHelper)
+    public function __construct(DoctrineHelper $entityHelper, FormTypeRenderer $formTypeRenderer)
     {
         $this->entityHelper = $entityHelper;
+        $this->formTypeRenderer = $formTypeRenderer;
     }
 
     public static function getCommandName(): string
@@ -81,10 +84,10 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
             'Type'
         );
 
-        $formFields = ['field_name'];
-        $boundClassVars = [];
+        $formFields = ['field_name' => null];
 
         $boundClass = $input->getArgument('bound-class');
+        $boundClassDetails = null;
 
         if (null !== $boundClass) {
             $boundClassDetails = $generator->createClassNameDetails(
@@ -100,17 +103,12 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen
                 $classDetails = new ClassDetails($boundClassDetails->getFullName());
                 $formFields = $classDetails->getFormFields();
             }
-
-            $boundClassVars = [
-                'bounded_full_class_name' => $boundClassDetails->getFullName(),
-                'bounded_class_name' => $boundClassDetails->getShortName(),
-            ];
         }
 
-        $generator->generateClass(
-            $formClassNameDetails->getFullName(),
-            'form/Type.tpl.php',
-            array_merge(['form_fields' => $formFields], $boundClassVars)
+        $this->formTypeRenderer->render(
+            $formClassNameDetails,
+            $formFields,
+            $boundClassDetails
         );
 
         $generator->writeChanges();