feature #1356 Allow Symfony 7 + Drop old Symfony version support (nicolas-grekas, weaverryan)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Allow Symfony 7 + Drop old Symfony version support

* PHP min version -> `8.1`
* Symfony min version -> `6.3`
* Drop support fully for annotations

Commits
-------

4da6e4a Bumping min php + symfony versions & removing legacy code
826b4f2 Allow Symfony 7

Author: weaverryan

.github/workflows/ci.yaml

@@ -22,7 +22,7 @@ jobs:
             fail-fast: false
             matrix:
                 php-version:
-                    - '8.0'
+                    - '8.1'
 
         steps:
             -
@@ -92,22 +92,19 @@ jobs:
                 php-version:
                     - '8.2'
                 symfony-version:
-                    - '5.4.*'
-                    - '5.4.x-dev'
-                    - '6.0.x-dev'
-                    - '6.1.x-dev'
-                    - '6.2.x-dev'
                     - '6.3.x-dev'
+                    - '6.4.x-dev'
+                    - '7.0.x-dev'
                 dependency-versions: ['highest']
                 allow-dev-deps-in-apps: ['0']
                 include:
-                    # testing lowest PHP version with LTS
-                    - php-version: '8.0.0'
-                      symfony-version: '5.4.*'
+                    # testing lowest PHP+dependencies with lowest Symfony
+                    - php-version: '8.1'
+                      symfony-version: '6.3.*'
                       dependency-versions: 'lowest'
-                    # testing lowest php version with highest 5.x stable
-                    - php-version: '8.0.0'
-                      symfony-version: '5.4.*'
+                    # testing lowest PHP+dependencies with highest Symfony
+                    - php-version: '8.1'
+                      symfony-version: '6.3.*'
                       dependency-versions: 'highest'
 
         steps:

appveyor.yml

@@ -27,7 +27,7 @@ environment:
     TEST_DATABASE_DSN: mysql://root:[email protected]:3306/test_maker
     matrix:
       - dependencies: highest
-        php_ver_target: 8.0.19
+        php_ver_target: 8.1.23
 
 install:
     - choco install sqlite --params "/NoTools"

composer.json

@@ -13,28 +13,28 @@
     ],
     "minimum-stability": "dev",
     "require": {
-        "php": ">=8.0",
+        "php": ">=8.1",
         "doctrine/inflector": "^2.0",
         "nikic/php-parser": "^4.11",
-        "symfony/config": "^5.4.7|^6.0",
-        "symfony/console": "^5.4.7|^6.0",
-        "symfony/dependency-injection": "^5.4.7|^6.0",
+        "symfony/config": "^6.3|^7.0",
+        "symfony/console": "^6.3|^7.0",
+        "symfony/dependency-injection": "^6.3|^7.0",
         "symfony/deprecation-contracts": "^2.2|^3",
-        "symfony/filesystem": "^5.4.7|^6.0",
-        "symfony/finder": "^5.4.3|^6.0",
-        "symfony/framework-bundle": "^5.4.7|^6.0",
-        "symfony/http-kernel": "^5.4.7|^6.0",
-        "symfony/process": "^5.4.7|^6.0"
+        "symfony/filesystem": "^6.3|^7.0",
+        "symfony/finder": "^6.3|^7.0",
+        "symfony/framework-bundle": "^6.3|^7.0",
+        "symfony/http-kernel": "^6.3|^7.0",
+        "symfony/process": "^6.3|^7.0"
     },
     "require-dev": {
         "composer/semver": "^3.0",
-        "doctrine/doctrine-bundle": "^2.4",
+        "doctrine/doctrine-bundle": "^2.4.3",
         "doctrine/orm": "^2.10.0",
-        "symfony/http-client": "^5.4.7|^6.0",
-        "symfony/phpunit-bridge": "^5.4.17|^6.0",
+        "symfony/http-client": "^6.3|^7.0",
+        "symfony/phpunit-bridge": "^6.3|^7.0",
         "symfony/polyfill-php80": "^1.16.0",
-        "symfony/security-core": "^5.4.7|^6.0",
-        "symfony/yaml": "^5.4.3|^6.0",
+        "symfony/security-core": "^6.3|^7.0",
+        "symfony/yaml": "^6.3|^7.0",
         "twig/twig": "^2.0|^3.0"
     },
     "config": {
@@ -43,8 +43,7 @@
     },
     "conflict": {
         "doctrine/orm": "<2.10",
-        "doctrine/doctrine-bundle": "<2.4",
-        "symfony/doctrine-bridge": "<5.4"
+        "doctrine/doctrine-bundle": "<2.4"
     },
     "autoload": {
         "psr-4": { "Symfony\\Bundle\\MakerBundle\\": "src/" }
@@ -54,7 +53,7 @@
     },
     "extra": {
         "branch-alias": {
-            "dev-main": "1.0-dev"
+            "dev-main": "1.x-dev"
         }
     }
 }

src/Console/MigrationDiffFilteredOutput.php

@@ -14,38 +14,7 @@
 use Symfony\Component\Console\Formatter\OutputFormatterInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
-// look for the "string|iterable" type on OutputInterface::write()
-// @legacy - Use MigrationDiffFilteredOutput_php8 when Symfony 5.4 is no longer supported
-if (!(new \ReflectionMethod(OutputInterface::class, 'write'))->getParameters()[0]->getType()) {
-    class MigrationDiffFilteredOutput implements OutputInterface
-    {
-        use BaseMakerMigrationDiffFilteredOuputTrait;
-
-        public function write($messages, $newline = false, $options = 0)
-        {
-            $this->_write($messages, $newline, $options);
-        }
-
-        public function writeln($messages, $options = 0)
-        {
-            $this->_writeln($messages, $options);
-        }
-
-        public function setVerbosity($level)
-        {
-            $this->output->setVerbosity($level);
-        }
-
-        public function setDecorated($decorated)
-        {
-            $this->output->setDecorated($decorated);
-        }
-    }
-} else {
-    require __DIR__.'/MigrationDiffFilteredOutput_php8';
-}
-
-trait BaseMakerMigrationDiffFilteredOuputTrait
+class MigrationDiffFilteredOutput implements OutputInterface
 {
     private string $buffer = '';
     private bool $previousLineWasRemoved = false;
@@ -55,20 +24,30 @@ public function __construct(
     ) {
     }
 
-    public function _write($messages, bool $newline = false, $options = 0)
+    public function write($messages, bool $newline = false, $options = 0): void
     {
         $messages = $this->filterMessages($messages, $newline);
 
         $this->output->write($messages, $newline, $options);
     }
 
-    public function _writeln($messages, int $options = 0)
+    public function writeln($messages, int $options = 0): void
     {
         $messages = $this->filterMessages($messages, true);
 
         $this->output->writeln($messages, $options);
     }
 
+    public function setVerbosity(int $level): void
+    {
+        $this->output->setVerbosity($level);
+    }
+
+    public function setDecorated(bool $decorated): void
+    {
+        $this->output->setDecorated($decorated);
+    }
+
     public function getVerbosity(): int
     {
         return $this->output->getVerbosity();
@@ -99,7 +78,7 @@ public function isDecorated(): bool
         return $this->output->isDecorated();
     }
 
-    public function setFormatter(OutputFormatterInterface $formatter)
+    public function setFormatter(OutputFormatterInterface $formatter): void
     {
         $this->output->setFormatter($formatter);
     }

src/Console/MigrationDiffFilteredOutput_php8

@@ -55,8 +55,7 @@ public function generateEntityClass(ClassNameDetails $entityClassDetails, bool $
         }
 
         if ($apiResource) {
-            // @legacy Drop annotation class when annotations are no longer supported.
-            $useStatements->addUseStatement(class_exists(ApiResource::class) ? ApiResource::class : \ApiPlatform\Core\Annotation\ApiResource::class);
+            $useStatements->addUseStatement(ApiResource::class);
         }
 
         $entityPath = $this->generator->generateClass(

src/Doctrine/EntityClassGenerator.php

@@ -11,7 +11,6 @@
 
 namespace Symfony\Bundle\MakerBundle\Doctrine;
 
-use Doctrine\Common\Persistence\Mapping\ClassMetadata as LegacyClassMetadata;
 use Doctrine\Persistence\Mapping\ClassMetadata;
 
 /**
@@ -22,7 +21,7 @@
 final class EntityDetails
 {
     public function __construct(
-        private ClassMetadata|LegacyClassMetadata $metadata,
+        private ClassMetadata $metadata,
     ) {
     }
 

src/Doctrine/EntityDetails.php

@@ -11,7 +11,6 @@
 
 namespace Symfony\Bundle\MakerBundle\Doctrine;
 
-use Doctrine\Common\Persistence\Mapping\MappingException as LegacyCommonMappingException;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\MappingException;
 use Doctrine\Persistence\Mapping\MappingException as PersistenceMappingException;
@@ -38,7 +37,7 @@ public function regenerateEntities(string $classOrNamespace): void
     {
         try {
             $metadata = $this->doctrineHelper->getMetadata($classOrNamespace);
-        } catch (MappingException|LegacyCommonMappingException|PersistenceMappingException) {
+        } catch (MappingException|PersistenceMappingException) {
             $metadata = $this->doctrineHelper->getMetadata($classOrNamespace, true);
         }
 

src/Doctrine/EntityRegenerator.php

@@ -14,7 +14,6 @@
 use Symfony\Component\Console\Event\ConsoleCommandEvent;
 use Symfony\Component\Console\Event\ConsoleErrorEvent;
 use Symfony\Component\Console\Event\ConsoleTerminateEvent;
-use Symfony\Component\EventDispatcher\Event as LegacyEvent;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\HttpKernel\Event\ControllerArgumentsEvent;
 use Symfony\Component\HttpKernel\Event\ControllerEvent;
@@ -35,7 +34,6 @@
 use Symfony\Component\Security\Core\Event\AuthenticationSuccessEvent;
 use Symfony\Component\Security\Http\Event\InteractiveLoginEvent;
 use Symfony\Component\Security\Http\Event\SwitchUserEvent;
-use Symfony\Contracts\EventDispatcher\Event;
 
 /**
  * @internal
@@ -148,11 +146,7 @@ public function getEventClassName(string $event): ?string
             }
 
             if (null !== $type = $args[0]->getType()) {
-                $type = $type instanceof \ReflectionNamedType ? $type->getName() : $type->__toString();
-
-                if (LegacyEvent::class === $type && class_exists(Event::class)) {
-                    return Event::class;
-                }
+                $type = $type instanceof \ReflectionNamedType ? $type->getName() : null;
 
                 // ignore an "object" type-hint
                 if ('object' === $type) {

src/EventRegistry.php

@@ -194,6 +194,7 @@ private function realPath(string $absolutePath): string
         }
 
         $finalPath = implode('/', $finalParts);
+
         // Normalize: // => /
         // Normalize: /./ => /
         return str_replace(['//', '/./'], '/', $finalPath);