Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doctrine Bundle] Pin versions in Dockerfile #1266

Closed
LaurentSanson opened this issue Dec 8, 2023 · 5 comments
Closed

[Doctrine Bundle] Pin versions in Dockerfile #1266

LaurentSanson opened this issue Dec 8, 2023 · 5 comments

Comments

@LaurentSanson
Copy link

Hi there,

I've encountered a small issue with the ORM bundle recipe and using the Hadolint on the CI (it all come from the Kevin's template).

Issue :
Error: Dockerfile:51 DL3018 warning: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

How to reproduce :

  • Use the template
  • Add ORM bundle
  • Git push on main branch

I'm guessing we could probably add a version of the package in the recipe as suggested?

Thanks !

@maxhelias
Copy link
Contributor

Hello,
This error should no longer occur with the latest version of recipes : https://github.com/symfony/recipes/blob/main/doctrine/doctrine-bundle/2.9/manifest.json#L19

@LaurentSanson
Copy link
Author

Oh great !! Thanks for the quick feedback

@LaurentSanson
Copy link
Author

@maxhelias I've just checked the recipes. The one you pointed at is the 2.9 and it's not the latest as there is a 2.10 => https://github.com/symfony/recipes/blob/main/doctrine/doctrine-bundle/2.10/manifest.json#L18

@maxhelias
Copy link
Contributor

I missed 2.10.. which should have the same dockerfile section as 2.9...

@LaurentSanson
Copy link
Author

No probs, I've created the PR. Tell me if it needs more info :)

@fabpot fabpot closed this as completed Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants