diff --git a/.circleci/config.yml b/.circleci/config.yml index 304c67e..c7148a4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -81,7 +81,7 @@ workflows: - tests-phpunit: matrix: parameters: - php-version: ['7.1', '7.2', '7.3', '7.4', '8.0'] + php-version: ['7.2', '7.3', '7.4', '8.0'] - release: requires: [tests-phpunit] filters: diff --git a/.phpunit.result.cache b/.phpunit.result.cache index b80bfb3..7e95d92 100644 --- a/.phpunit.result.cache +++ b/.phpunit.result.cache @@ -1 +1 @@ -{"version":1,"defects":{"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testConstructorWithoutOption":6,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #0":6,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #1":6,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #2":6},"times":{"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testConstructorWithoutOption":0.007,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProjects":0.021,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProjectsWithPage":0.004,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProject":0.008,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testCreateProjectOk":0.008,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testCreateProjectNOk":0.001,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testupdateProjectOk":0.008,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testupdateProjectNOk":0.001,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalyses":0.002,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalysis":0.007,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalysisStatus":0.002,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testAnalyze":0.008,"SensioLabs\\Insight\\Tests\\Sdk\\Model\\ViolationsTest::testCount":0,"SensioLabs\\Insight\\Tests\\Sdk\\Model\\ViolationsTest::testIterable":0,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #0":0,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #1":0,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #2":0.001,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrors":0}} \ No newline at end of file +{"version":1,"defects":{"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testConstructorWithoutOption":6,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #0":6,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #1":6,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #2":6,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProjects":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProjectsWithPage":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProject":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testCreateProjectOk":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testCreateProjectNOk":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testupdateProjectOk":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testupdateProjectNOk":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalyses":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalysis":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalysisStatus":4,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testAnalyze":4},"times":{"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testConstructorWithoutOption":0.005,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProjects":0.026,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProjectsWithPage":0.006,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetProject":0.183,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testCreateProjectOk":0.185,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testCreateProjectNOk":0.001,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testupdateProjectOk":0.184,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testupdateProjectNOk":0.001,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalyses":0.004,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalysis":0.163,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testGetAnalysisStatus":0.004,"SensioLabs\\Insight\\Sdk\\Tests\\ApiTest::testAnalyze":0.164,"SensioLabs\\Insight\\Tests\\Sdk\\Model\\ViolationsTest::testCount":0,"SensioLabs\\Insight\\Tests\\Sdk\\Model\\ViolationsTest::testIterable":0,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #0":0,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #1":0,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrorsFailedIfDocumentIfInvalid with data set #2":0,"SensioLabs\\Insight\\Sdk\\Tests\\ParserTest::testParseErrors":0}} \ No newline at end of file diff --git a/Sdk/Tests/ApiTest.php b/Sdk/Tests/ApiTest.php index a565707..c9d4a5c 100644 --- a/Sdk/Tests/ApiTest.php +++ b/Sdk/Tests/ApiTest.php @@ -30,13 +30,11 @@ protected function setUp(): void $this->logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock(); } - /** - * @expectedException \Exception - * @expectedExceptionMessage Config is missing the following keys: api_token, user_uuid - */ public function testConstructorWithoutOption() { - $api = new Api(); + $this->expectException(\Exception::class); + $this->expectExceptionMessage('Config is missing the following keys: api_token, user_uuid'); + new Api(); } public function testGetProjects() diff --git a/Sdk/Tests/ParserTest.php b/Sdk/Tests/ParserTest.php index 96619ba..d65d3a6 100644 --- a/Sdk/Tests/ParserTest.php +++ b/Sdk/Tests/ParserTest.php @@ -12,6 +12,7 @@ namespace SensioLabs\Insight\Sdk\Tests; use PHPUnit\Framework\TestCase; +use SensioLabs\Insight\Sdk\Exception\ApiParserException; use SensioLabs\Insight\Sdk\Parser; class ParserTest extends TestCase @@ -36,13 +37,13 @@ public function getParseErrorsFailedIfDocumentIfInvalidTests() } /** - * @expectedException \SensioLabs\Insight\Sdk\Exception\ApiParserException - * @expectedExceptionMessage Could not transform this xml to a \DOMDocument instance. * @dataProvider getParseErrorsFailedIfDocumentIfInvalidTests */ public function testParseErrorsFailedIfDocumentIfInvalid($xml) { - $error = $this->parser->parseError($xml); + $this->expectException(ApiParserException::class); + $this->expectExceptionMessage('Could not transform this xml to a \DOMDocument instance.'); + $this->parser->parseError($xml); } public function testParseErrors() diff --git a/composer.json b/composer.json index de9d52a..76abedd 100644 --- a/composer.json +++ b/composer.json @@ -3,9 +3,9 @@ "description": "SymfonyInsight SDK", "license": "MIT", "require": { - "php": ">=7.1", + "php": ">=7.2", "ext-json": "*", - "jms/serializer": "0.12.*", + "jms/serializer": "^3.17", "psr/log": "^1.0", "symfony/http-client": "^4.4", "symfony/console": "^4.4",