Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all direct calls of zenity / increase granularity of 'd' function #41

Open
sysrich opened this issue Aug 1, 2024 · 1 comment

Comments

@sysrich
Copy link
Owner

sysrich commented Aug 1, 2024

In line to support running tik purely from a terminal, we need to make sure that all 'GUI'/dialogue calls are hidden behind the 'd' or other similar functions

There are currently two use cases for not using 'd' in the tik codebase

  1. the command is 'optional' and/or can successfully exit with a non-zero error code. 'd' assumes that any non-zero error code from zenity is a failure and that the user wishes to exit tik. The therefore needs to be a switch or alternative form of 'd' ('d-opt maybe?) that doesn't assume non-zero error codes are requests to exit tik
  2. the command and it's output shouldn't be logged. 'd' currently writes what it does to tik.log, but this isn't ideal when being used to display messages including Recovery Keys. There therefore needs to be a switch or alternative form of 'd' ('d-priv' maybe?) that doesn't write to tik.log
@sysrich
Copy link
Owner Author

sysrich commented Jan 2, 2025

  1. has been addressed by d_opt
  2. has been addressed by introducing a new logging= variable which means we can temporarily disable logging in a function

So I think this can be closed once we remove the last few zenity+cenity explicit calls, which seem to be --password calls only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant