Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifier for the image name (as used in Dependencies=) #2566

Closed
NekkoDroid opened this issue Mar 28, 2024 · 0 comments · Fixed by #3182
Closed

Specifier for the image name (as used in Dependencies=) #2566

NekkoDroid opened this issue Mar 28, 2024 · 0 comments · Fixed by #3182
Labels

Comments

@NekkoDroid
Copy link
Contributor

NekkoDroid commented Mar 28, 2024

Currently there is no way to refer to the name of a given image when using mkosi.images, which is a minor problem when ImageVersion= is set as the output name will have the version appended which isn't always desirable (e.g. grouping all output in a subdirectory that has the version embedded mkosi.output/v1.0/...).

With a specifier for the name you can reduce the duplication where the image name is explicitly named and needs to be kept up-to-date when making changes.

NekkoDroid added a commit to NekkoDroid/mkosi that referenced this issue Nov 11, 2024
This expands to the name of the subimage (and an empty string for the
main image) and is the same value that is used for Dependencies=.

Fixes: systemd#2566
NekkoDroid added a commit to NekkoDroid/mkosi that referenced this issue Nov 12, 2024
This expands to the name of the subimage (and an empty string for the
main image) and is the same value that is used for Dependencies=.

Fixes: systemd#2566
NekkoDroid added a commit to NekkoDroid/mkosi that referenced this issue Nov 12, 2024
This expands to the name of the subimage (and an empty string for the
main image) and is the same value that is used for Dependencies=.

Fixes: systemd#2566
NekkoDroid added a commit to NekkoDroid/mkosi that referenced this issue Nov 12, 2024
This expands to the name of the subimage (and an empty string for the
main image) and is the same value that is used for Dependencies=.

Fixes: systemd#2566
NekkoDroid added a commit to NekkoDroid/mkosi that referenced this issue Nov 12, 2024
This expands to the name of the subimage (and an empty string for the
main image) and is the same value that is used for Dependencies=.

Fixes: systemd#2566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants