Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling details with Phone number not working as expected #82

Open
jaapjansma opened this issue Jul 16, 2021 · 0 comments · May be fixed by #83
Open

Filling details with Phone number not working as expected #82

jaapjansma opened this issue Jul 16, 2021 · 0 comments · May be fixed by #83
Labels
status:needs review Code needs review and testing
Milestone

Comments

@jaapjansma
Copy link
Contributor

jaapjansma commented Jul 16, 2021

With the fill details options I would expect that a phone number is added when no phone number with the location type and phone type exists.

When a phone number with that location type and phone type already exists I would expect that nothing changes. However the new phone number gets added and I end up with two phones of the same location type and phone type.

Steps to reproduce

  1. Create an XCM Profile with no overriding details and at fill details select phone, for location type select home and phone type phone
  2. On this profile match on external identifier
  3. Create a contact with external identifier 123aa and add a phone number 0123456789 with location type home and phone type phone
  4. Now use the XCM profile to lookup/create a contact. I have used the form processor for this. Provide data as follows, external identifier 123aa and add the phone number 987654321 (the phone number is different)

Expected result

Nothing will happen because a phone with the location type home and phone type phone already exists.

Actual result

The phone number gets added and the contacts has two phone number with location type home and phone type phone

Remarks

It is possible to have multiple phone numbers with the same location type and phone type. So in one sense this behavior is correct.

However in my specific use case this is exactly not what we want.

For the address field we already have such options. Fill if contact has no address, or fill if contact no address of that type.

jaapjansma added a commit to jaapjansma/de.systopia.xcm that referenced this issue Jul 16, 2021
@jensschuppe jensschuppe linked a pull request Jul 3, 2023 that will close this issue
@jensschuppe jensschuppe added this to the 1.12 milestone Sep 14, 2023
@jensschuppe jensschuppe added the status:needs review Code needs review and testing label Sep 14, 2023
@bjendres bjendres modified the milestones: 1.12, 1.13 Oct 11, 2023
@jensschuppe jensschuppe modified the milestones: 1.13, 1.14 Jun 25, 2024
jaapjansma added a commit to jaapjansma/de.systopia.xcm that referenced this issue Aug 20, 2024
jaapjansma added a commit to jaapjansma/de.systopia.xcm that referenced this issue Aug 20, 2024
jaapjansma added a commit to jaapjansma/de.systopia.xcm that referenced this issue Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs review Code needs review and testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants