-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet auth #81
base: member-list-ui
Are you sure you want to change the base?
Wallet auth #81
Conversation
The app checks for miami coin balance and then gives user access if he has any coins present Signed-off-by: Suleman Mahmood <[email protected]>
contact call to read only function added to verify whether the loggin in user is a registered member of the miami vice or not
Build is failing on CF for some reason. Check the logs. Other than that, this is an AWESOME PR!! thank you! gonna test it out and give it an approval or not later. cc @314159265359879 for his review too. assigning reviews now... |
34c8597
to
131ce57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work and initiative on this!
packages/ui/components/auth.tsx
Outdated
// Set this to true if you want to use Mainnet | ||
// Using a boolean helps to switch the entire application to mainnet | ||
// or testnet with only changing a single value | ||
const isNetworkMainnet = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the docs here (https://nextjs.org/docs/basic-features/environment-variables).
Making .env.development or .env files isn't working and environment variables aren't loaded up.
Spent an hour trying to make them to work but no progress :(
Dunno, what am I doing wrong
I have added the environment variable files and their usage in the commit. So maybe you can look into what am I doing wrong :x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you create .env.local
in packages/ui
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have created all types of .env
files in packages/ui
and have logged the object process.env
in the console and it appears to be empty. The environment variable doesn't seem to get loaded :/
Excellent work, I am keeping an eye on this, will test when the page builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put your .env.local
file in the root directory of the project and it will work. I mistakenly suggested packages/ui
.
@@ -27,8 +27,16 @@ function Drawer({ | |||
expanded, | |||
handleCloseClick, | |||
closeDrawer, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can set a default value here of closeDrawer=()=>{}
so we don't need to pass in an empty function in our other components when we want to use Drawer
Features added:
Minor Changes:
Changes left: