Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Typed.List to get_matching_indices #110

Open
szhan opened this issue Jun 21, 2023 · 2 comments
Open

Pass Typed.List to get_matching_indices #110

szhan opened this issue Jun 21, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@szhan
Copy link
Owner

szhan commented Jun 21, 2023

In the future, support of the use of list will be deprecated in numba. See Deprecation of reflection for List and Set types.

get_matching_indices and remap_genotypes should be updated accordingly.
@szhan
Copy link
Owner Author

szhan commented Jun 24, 2023

Not doing this because I'll disable numba during testing instead. See #124

@szhan szhan closed this as completed Jun 24, 2023
@szhan szhan reopened this Jun 24, 2023
@szhan
Copy link
Owner Author

szhan commented Jun 24, 2023

No, oops, I forgot. This is a separate issue about future deprecation.

@szhan szhan added the enhancement New feature or request label Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szhan