Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats from production runs #251

Open
joto opened this issue Jul 13, 2021 · 2 comments
Open

Stats from production runs #251

joto opened this issue Jul 13, 2021 · 2 comments

Comments

@joto
Copy link

joto commented Jul 13, 2021

I see that statistics collection is already built into t-rex, but it is only exposed in the drilldown command. I would like to get the statistics also in normal production so that I can continually track stats and see when there are regressions after changes etc.

I am not sure yet what the best format is. For the time being maybe having an extra (csv) log file that logs the stats would be okay, medium term we could add fancy things like putting the stats into special databases or whatever.

@pka
Copy link
Member

pka commented Aug 27, 2021

Would you expect these runtime statistics also on defined points (like drilldown), or in other tiles as well?

My favorite solution would be an instrumentation providing an endpoint with Prometheus metrics.

@joto
Copy link
Author

joto commented Aug 28, 2021

Would you expect these runtime statistics also on defined points (like drilldown), or in other tiles as well?

I think the stats should be generated for all tiles. If you only want it at defined points, drilldown is fine. But there is always the problem that the planet (and the data) is not homogenous, so what might work well on one part of the planet might be slow on other parts.

My favorite solution would be an instrumentation providing an endpoint with Prometheus metrics.

Good for Prometheus users, not so good for others. Maybe we can define some kind of interface in the code where people can plug into? Not sure if it is worth the effort though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants