Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(on-off): allow sending on and off commands, when already on or off #327

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

t0bst4r
Copy link
Owner

@t0bst4r t0bst4r commented Dec 17, 2024

fixes #320

Copy link

nx-cloud bot commented Dec 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d9ebfca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@t0bst4r t0bst4r merged commit 7c37dc1 into main Dec 19, 2024
2 checks passed
@t0bst4r t0bst4r deleted the onoff branch December 19, 2024 20:11
@Kaskadeur111
Copy link

Thanks! Works like a charm now!! 😀

@Kaskadeur111
Copy link

Kaskadeur111 commented Dec 22, 2024

Hey, haut doch noch nicht ganz hin! Es scheint noch einen kleinen Formatfehler zu geben.

Der Trigger reagiert nicht

Szenario 1: Helper Switch wird per Alexa eingeschaltet, dann muss der Trigger so aussehen um auszulösen
image

Szenario 2: Helper Switch wird per Dashboard (Standard Schalter-Widget von HA )eingeschaltet, dann reagiert der Trigger nur wenn er so aussieht:
image

Ich kann also gerade nur auf Dashboard Bedienung ODER auf Alexa Triggern... (müsste also anstatt zwei Triggern für on und off jetzt 4 Trigger (je 2 für on und 2 für off in unterschiedlicher Syntax schreiben)

Ich denke du müsstest die entity_id in der service_data ohne Minus und Zeilenumbruch übergeben.

Also eigentlich braucht man den Bindestrich ja nicht, da sowieso immer nur ein Gerät angesteuert werden kann.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: call_service event is not sent to HA Event Bus if the state doesnt change
2 participants