Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tachyons-sass violates the licence of its one upstream project #34

Open
mirabilos opened this issue Nov 22, 2018 · 12 comments
Open

tachyons-sass violates the licence of its one upstream project #34

mirabilos opened this issue Nov 22, 2018 · 12 comments

Comments

@mirabilos
Copy link

During swagger-api/swagger-ui#5042 I found out that tachyons embeds code from https://github.com/necolas/normalize.css/ without reproducing its copyright statement and full licence terms, as required by the MIT licence.

The source code simply has https://github.com/tachyons-css/tachyons-sass/blob/master/tachyons.scss#L28 so https://github.com/tachyons-css/tachyons-sass/blob/master/license better be changed to reproduce https://github.com/necolas/normalize.css/blob/master/LICENSE.md in full.

However (see the swagger-ui-dist issue above) this is also a problem for your downstreams. The generated CSS file distributed from your NPM module contains necolas/normalize.css code without its full licence terms and statements. A method of aggregation would be best, or perhaps embed it into the generated CSS (even though that would kinda defeat minification).

@DanielRuf
Copy link

Afaik it is sufficient to use this short license header. We do not want the full license text in all (minified) files.

Also the MIT license text is always the same.

@DanielRuf
Copy link

Also see https://stackpath.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css

This is common and ok.

Otherwise you would have to open an issue for all frontend frameworks and other projects.

@mirabilos
Copy link
Author

mirabilos commented Feb 16, 2019 via email

@DanielRuf
Copy link

DanielRuf commented Feb 16, 2019

I think @jonathantneal and the whole dev community (including me) do not see it like this.

@DanielRuf
Copy link

https://www.iusmentis.com/computerprograms/opensourcesoftware/license-notices-web-applications/

A reference to the license is still ok. Like I wrote.

https://unpkg.com/[email protected]/umd/react.production.min.js

As we do not ship the source but compiled files it is ok to reference to the license location.

The generated MIT license on GitHub and on other platforms is always identical except the owner name and year differ. Modifying a license text makes it a whole different license.

What you propose is not practical and would not make any change when we use minifiers which strip comments.

@DanielRuf
Copy link

https://code.jquery.com/jquery-3.3.1.min.js
https://code.jquery.com/jquery-3.3.1.js

Good luck opening an issue in every JS / CSS project and so on.

@mirabilos
Copy link
Author

mirabilos commented Feb 16, 2019 via email

@DanielRuf
Copy link

I had to manually add it in the one project I’m using swagger-ui-dist in, in order to stay legally compliant.

So you deliver all this data to the client? Great for the performance. This is still not the sourcecode, the repo is and has the license file.

@DanielRuf
Copy link

I can read and what you propose is very unlikely to happen (in almost all projects).

Same for font files, they have metadata which includes a reference to the full license, not the full license. Otherwise we would have huge assets.

@DanielRuf
Copy link

The GNU GPL is designed so that you can easily apply it to your own program if you are the copyright holder. You don't have to modify the GNU GPL to do this, just add notices to your program which refer properly to the GNU GPL. Please note that you must use the entire text of the GPL, if you use it. It is an integral whole, and partial copies are not permitted. (Likewise for the LGPL, AGPL, and FDL.)

Notices like license headers are common which refer to the location of the full license text.

http://kendo.cdn.telerik.com/2019.1.115/js/kendo.all.min.js

I still see no issue here.

@jonathantneal
Copy link

Please just include whatever our projects do in whatever the ways our projects do them. In normalize.css, the reference is pretty short:

/*! normalize.css v8.0.1 | MIT License | github.com/necolas/normalize.css */

Thanks! I certify this or whatever as a co-creator of normalize.css and as one who helped published some of the more recent releases.

Seriously, I’d have licensed it CC0 if I knew what a pain in the neck licensing can be. What’s done is done. I won’t have more to add to this thread, and I have nothing but love and respect for you all. If Nic has anything more to add, please follow his lead. Pardon me if I peace out ✌️

@mirabilos
Copy link
Author

mirabilos commented Feb 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants