Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0 [duplicate] #67

Open
ajaynarang opened this issue Jan 2, 2023 · 2 comments

Comments

@ajaynarang
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/tachyons-sass/scss/_clears.scss b/node_modules/tachyons-sass/scss/_clears.scss
index d4c2fc3..4ed07de 100644
--- a/node_modules/tachyons-sass/scss/_clears.scss
+++ b/node_modules/tachyons-sass/scss/_clears.scss
@@ -18,7 +18,7 @@
 .cf:before,
 .cf:after { content: " "; display: table; }
 .cf:after { clear: both; }
-.cf {       *zoom: 1; }
+.cf { zoom: 1; }
 
 .cl { clear: left; }
 .cr { clear: right; }
diff --git a/node_modules/tachyons-sass/scss/_widths.scss b/node_modules/tachyons-sass/scss/_widths.scss
index abc4fc7..322dfca 100644
--- a/node_modules/tachyons-sass/scss/_widths.scss
+++ b/node_modules/tachyons-sass/scss/_widths.scss
@@ -70,8 +70,8 @@
 .w-90 {  width:  90%; }
 .w-100 { width: 100%; }
 
-.w-third { width: (100% / 3); }
-.w-two-thirds { width: (100% / 1.5); }
+.w-third { width: calc(100% / 3); }
+.w-two-thirds { width: calc(100% / 1.5); }
 .w-auto { width: auto; }
 
 @media #{$breakpoint-not-small} {
@@ -94,8 +94,8 @@
   .w-80-ns { width:  80%; }
   .w-90-ns { width:  90%; }
   .w-100-ns { width: 100%; }
-  .w-third-ns { width: (100% / 3); }
-  .w-two-thirds-ns { width: (100% / 1.5); }
+  .w-third-ns { width: calc(100% / 3); }
+  .w-two-thirds-ns { width: calc(100% / 1.5); }
   .w-auto-ns { width: auto; }
 }
 
@@ -119,8 +119,8 @@
   .w-80-m { width:  80%; }
   .w-90-m { width:  90%; }
   .w-100-m { width: 100%; }
-  .w-third-m { width: (100% / 3); }
-  .w-two-thirds-m { width: (100% / 1.5); }
+  .w-third-m { width: calc(100% / 3); }
+  .w-two-thirds-m { width: calc(100% / 1.5); }
   .w-auto-m {    width: auto; }
 }
 
@@ -144,7 +144,7 @@
   .w-80-l {    width:  80%; }
   .w-90-l {    width:  90%; }
   .w-100-l {   width: 100%; }
-  .w-third-l { width: (100% / 3); }
-  .w-two-thirds-l { width: (100% / 1.5); }
+  .w-third-l { width: calc(100% / 3); }
+  .w-two-thirds-l { width: calc(100% / 1.5); }
   .w-auto-l {    width: auto; }
 }

This issue body was partially generated by patch-package.

@Kikobeats
Copy link

@ajaynarang can you turn this into a PR? 🙏

@l3ender
Copy link

l3ender commented Aug 26, 2024

I believe this is a duplicate of #56, which has been merged but not yet released (see #68 for release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants