Draft
Conversation
rawpixel-vincent
force-pushed
the
feat/snapshot-processing
branch
from
d7b34dd to
94f4181
Compare
rawpixel-vincent
force-pushed
the
feat/snapshot-processing
branch
from
94f4181 to
4e24549
Compare
Contributor
Author
|
@pateketrueke you can check the options I added when you have time and let me know if it looks ok to you |
pateketrueke
reviewed
Oct 7, 2022
| ...parsed.reduce((acc, cur) => { | ||
| if (cur.quality && !isNaN(cur.quality)) { | ||
| cur.quality = parseInt(cur.quality, 10); | ||
| acc = { ...acc, ...cur }; |
Collaborator
There was a problem hiding this comment.
even if this works, you don't need to reassign the accumulator, only extend it, e.g.
+acc.quality = parseInt(cur.quality, 10);
-cur.quality = parseInt(cur.quality, 10);
-acc = { ...acc, ...cur };the same happen with all options, and the code will be less 🐝
Contributor
Author
There was a problem hiding this comment.
makes sense 👌🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--take-snapshotcli options listwould fix #48