Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renounceOwnership to OwnableTransferable #32

Open
talkol opened this issue Mar 11, 2023 · 3 comments
Open

Add renounceOwnership to OwnableTransferable #32

talkol opened this issue Mar 11, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request stdlib The Tact standard library
Milestone

Comments

@talkol
Copy link
Member

talkol commented Mar 11, 2023

It's a good idea to standardize what it means to transfer ownership to nobody

Probably transfer to newAddress(0,0) - but we don't want users to think about these implementation details

@ex3ndr
Copy link
Member

ex3ndr commented Mar 11, 2023

Also have a burner address to transfer assets to. I just not sure if this would be safe and won't give an easy way to make mistakes

@talkol
Copy link
Member Author

talkol commented Mar 11, 2023

If ownership is indeed renounced and a user is going to an explorer to verify that, it will be nicer if the explorer prints out something standard instead of showing base64 encoding of the zero address which nobody will understand

Another reason to standardize the zero address as nobody

@talkol
Copy link
Member Author

talkol commented Mar 11, 2023

I don't think adding renounceOwnership as a new message adds potential mistakes, It's not much different from sending by mistake your tokens to the wrong place or by accident transfer ownership to the wrong address

This is also the pattern on EVM:

https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/access/Ownable.sol

@anton-trunov anton-trunov added the stdlib The Tact standard library label Feb 16, 2024
@anton-trunov anton-trunov added this to the v1.3.0 milestone Feb 16, 2024
@anton-trunov anton-trunov added the enhancement New feature or request label Feb 16, 2024
@Gusarich Gusarich self-assigned this Feb 27, 2024
@anton-trunov anton-trunov modified the milestones: v1.3.0, v1.4.0 Apr 19, 2024
@Gusarich Gusarich modified the milestones: v1.4.0, v1.5.0 Jun 11, 2024
@anton-trunov anton-trunov modified the milestones: v1.5.0, v1.6.0 Jul 30, 2024
@anton-trunov anton-trunov modified the milestones: v1.6.0, v1.7.0 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stdlib The Tact standard library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants