Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rows with diacritic signature of IPASkeleton #11

Open
taesungh opened this issue Nov 21, 2024 · 0 comments
Open

Refactor rows with diacritic signature of IPASkeleton #11

taesungh opened this issue Nov 21, 2024 · 0 comments

Comments

@taesungh
Copy link
Owner

Currently, the IPASkeleton class has a diacriticSignature property for tracking the signature of diacritics on each row of the table. This needs to have the same length as the cells matrix and is inherently detached from the table structure. It would be more cohesive to have a single object represent a row of the table along with a property for the diacritic signature. That way, each row holds both the cells and the signature as a unit.

  • Refactor the cells matrix to be an array of Row objects which hold the cells in that row along with the diacritic signature
    • It might be possible to extend the built-in Array type to include the custom property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant