Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep InventoryEditor component mounted even when dialog is closed #3

Open
taesungh opened this issue Oct 29, 2024 · 0 comments
Open

Comments

@taesungh
Copy link
Owner

The InventoryEditor component is rendered only when editorDialogOpen is set to true in InventorySelector. This causes the editor to refetch the IPA skeleton data files each time the editor is opened (although the network requests should be cached). This can be avoided by keeping the component mounted and allowing the open prop of the Dialog element inside to control the display. This will also allow the last selected tab (consonants, other, vowels) to stay selected when closing and reopening the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant