Github Docker Builds

[tagyoureit]

I finally took a crack at automatically building Docker images via Github actions. Would be great to have a few people test this out and make sure it works as expected.

Docker homepage: https://hub.docker.com/r/tagyoureit/njspc-dp-combined-app

Currently, the only build is Ubuntu with njsPC and dP. Builds happen automatically with each commit to the main njsPC repo.

[treyrich]

I just pulled this down and started testing it out. My first question is, what is the reasoning behind combining the dashpanel and the controller into a single image as opposed to separating them? This would allow for the avoidance of pm2 entirely.

Glad to see this getting integrated!

[tagyoureit]

I'm not a Docker expert and was working based off the excellent work that @emes started a long time ago. I was going for more simplicity on the setup side, but can also offer other options such as separate images if there is a need or that's standard practice. PM2 has been our go-to app monitor for a long time and it plays nicely with docker and allowed for starting of separate apps inside the same image. Agree it wouldn't be needed if there were separate images.

[treyrich]

Got it. Yeah I can see how this would make sense if you don't have much experience with Docker. For sure the best practice is to break these out into separate images, and then let whatever container runtime you're using handle lifecycle management/monitoring.

Besides this being standard practice, and therefore what people expect, there are several practical benefits to doing things this way as well, many are spelled out well here in this SO answer.

I would be happy to put together a PR to assist with this if you'd like? Or I'm also happy to simply review/test and provide feedback. Let me know how I can help!

[tagyoureit]

A PR would be great if you want to make some changes. TIA.

[treyrich]

Ok. So I've created a draft PR. I'd love to get some input before I finalize it in case there was a reason for all of the different dockerfiles and all the commented code in the workflow. Assuming that there wasn't any reasoning behind those, I think it's pretty close. I do think that we'll want to change the name of the docker image as this isn't 'combined'.

Assuming this is acceptable I'm happy to put together a similar PR for the dash panel project, though I don't personally use that project.

[tagyoureit]

It looks good to me. I had trouble getting QEMU\Buildx set up... too many tutorials all competing with each other.

Most of the comments were part of the trial & error or for future builds. But they aren't needed. I put a couple minor questions in the PR. Thanks and please do put together a similar workflow for dashPanel.