Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded corner effect doesn't work well on KDE-Rounded-Corners #34

Open
queenbiscuit311 opened this issue Apr 4, 2024 · 5 comments · Fixed by #68
Open

Rounded corner effect doesn't work well on KDE-Rounded-Corners #34

queenbiscuit311 opened this issue Apr 4, 2024 · 5 comments · Fixed by #68
Labels
0. type: enhancement New feature or request
Milestone

Comments

@queenbiscuit311
Copy link

queenbiscuit311 commented Apr 4, 2024

I've been using this effect for a little while on plasma 6 and while it's great, there's something about it that annoys me. If you use lightlyshaders and set the blur roundness to the same radius as lightlyshaders, everything looks pretty much identical to if I was using the lightlyshaders blur. However, lightlyshaders shadows look really ugly on my theme, so I'm using KDE-Rounded-Corners. But when using that effect, the rounding doesn't quite look right. When using 12px window rounding and 12px blur rounding, it gives this weird beveled edge effect that doesn't quite look right.

image

KDE-Rounded-Corners

image

LightlyShaders

Setting blur radius to 14px makes it look better, but in certain situations it is quite obvious that the blur radius is smaller than the window radius.

image

It's a very minor issue but I thought it would be a good idea to make an issue for it.

@taj-ny taj-ny added the 0. type: enhancement New feature or request label Apr 4, 2024
@taj-ny taj-ny added the help wanted Extra attention is needed label Apr 17, 2024
@taj-ny
Copy link
Owner

taj-ny commented May 4, 2024

I changed the position of this effect in the effect chain in order to make it run after KDE-Rounded-Corners/LightlyShaders and it's very glitchy, but the blur region is rounded and looks very nice. I should be able to reuse the shader from one of these projects. The catch is that the corners will be rounded twice - once for the blur region and once for the window.

@taj-ny taj-ny removed the help wanted Extra attention is needed label May 4, 2024
@taj-ny
Copy link
Owner

taj-ny commented May 6, 2024

I couldn't get KDE-Rounded-Corners' shader to work, so I used a different one. Here's the best result I've been able to achieve with a 12px window radius.
image

With slightly more antialiasing:
image

Without antialiasing for comparison:
image

Still not perfect, but in my opinion it's better than before.

@queenbiscuit311
Copy link
Author

that is definitely looking much better than before! would be happy to test if needed

@taj-ny taj-ny linked a pull request May 9, 2024 that will close this issue
12 tasks
@taj-ny
Copy link
Owner

taj-ny commented Jun 17, 2024

Partially fixed in v1.3.0. Looks much better but still not perfect. I could probably make it look perfect by blending the window texture with the blur, which would allow KDE-Rounded-Corners/LightlyShaders to also round the blur region, but the side effect would be blurry windows when using scaling even without rounded corners.

@taj-ny
Copy link
Owner

taj-ny commented Nov 28, 2024

In v1.4.0 I'll use KDE-Rounded-Corners' method of rounding corners, which will finally make them look perfect without any side effects.

@taj-ny taj-ny added this to the v1.4.0 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants