-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounded corner effect doesn't work well on KDE-Rounded-Corners #34
Comments
I changed the position of this effect in the effect chain in order to make it run after KDE-Rounded-Corners/LightlyShaders and it's very glitchy, but the blur region is rounded and looks very nice. I should be able to reuse the shader from one of these projects. The catch is that the corners will be rounded twice - once for the blur region and once for the window. |
that is definitely looking much better than before! would be happy to test if needed |
Partially fixed in v1.3.0. Looks much better but still not perfect. I could probably make it look perfect by blending the window texture with the blur, which would allow KDE-Rounded-Corners/LightlyShaders to also round the blur region, but the side effect would be blurry windows when using scaling even without rounded corners. |
In v1.4.0 I'll use KDE-Rounded-Corners' method of rounding corners, which will finally make them look perfect without any side effects. |
I've been using this effect for a little while on plasma 6 and while it's great, there's something about it that annoys me. If you use lightlyshaders and set the blur roundness to the same radius as lightlyshaders, everything looks pretty much identical to if I was using the lightlyshaders blur. However, lightlyshaders shadows look really ugly on my theme, so I'm using KDE-Rounded-Corners. But when using that effect, the rounding doesn't quite look right. When using 12px window rounding and 12px blur rounding, it gives this weird beveled edge effect that doesn't quite look right.
KDE-Rounded-Corners
LightlyShaders
Setting blur radius to 14px makes it look better, but in certain situations it is quite obvious that the blur radius is smaller than the window radius.
It's a very minor issue but I thought it would be a good idea to make an issue for it.
The text was updated successfully, but these errors were encountered: