From f82f3ced1c2583fd55b44319a1a89f7c66e27201 Mon Sep 17 00:00:00 2001 From: juyeon Date: Tue, 14 May 2024 10:35:12 +0900 Subject: [PATCH 1/6] fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a3b30d1..e9d9240 100644 --- a/README.md +++ b/README.md @@ -168,7 +168,7 @@ SwiftRater.daysBeforeReminding = 7 SwiftRater.appLaunched() ``` -If you wanted to show the rquest after a user performs 10 significant actions before 5 days or 5 uses have passed: +If you wanted to show the request after a user performs 10 significant actions before 5 days or 5 uses have passed: ``` SwiftRater.conditionsMetMode = .any From 2a8f13a8c8832eca70ab30a3ed14010ab7919789 Mon Sep 17 00:00:00 2001 From: juyeon Date: Tue, 14 May 2024 11:24:50 +0900 Subject: [PATCH 2/6] Adding point argument in incrementSignificantUseCount --- SwiftRater/UsageDataManager.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SwiftRater/UsageDataManager.swift b/SwiftRater/UsageDataManager.swift index b3c02e9..30b93c0 100644 --- a/SwiftRater/UsageDataManager.swift +++ b/SwiftRater/UsageDataManager.swift @@ -177,8 +177,8 @@ class UsageDataManager { usesCount = usesCount + 1 } - func incrementSignificantUseCount() { - significantEventCount = significantEventCount + 1 + func incrementSignificantUseCount(point: Int = 1) { + significantEventCount = significantEventCount + point } func saveReminderRequestDate() { From b8ca82d4dd7ce974cdd84d6be71818a2b07c5e01 Mon Sep 17 00:00:00 2001 From: Takeshi Fujiki Date: Thu, 4 Jul 2024 22:50:03 +0900 Subject: [PATCH 3/6] Update deployment version --- Demo/Demo.xcodeproj/project.pbxproj | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Demo/Demo.xcodeproj/project.pbxproj b/Demo/Demo.xcodeproj/project.pbxproj index f3ac11b..e686fdb 100644 --- a/Demo/Demo.xcodeproj/project.pbxproj +++ b/Demo/Demo.xcodeproj/project.pbxproj @@ -518,6 +518,7 @@ "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; DEVELOPMENT_TEAM = 495G5CPHRQ; INFOPLIST_FILE = Demo/Info.plist; + IPHONEOS_DEPLOYMENT_TARGET = 12.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.cocomoe.carp; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -537,6 +538,7 @@ "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; DEVELOPMENT_TEAM = 495G5CPHRQ; INFOPLIST_FILE = Demo/Info.plist; + IPHONEOS_DEPLOYMENT_TARGET = 12.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.cocomoe.carp; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -553,6 +555,7 @@ BUNDLE_LOADER = "$(TEST_HOST)"; DEVELOPMENT_TEAM = XEV6645KTD; INFOPLIST_FILE = DemoTests/Info.plist; + IPHONEOS_DEPLOYMENT_TARGET = 12.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.takecian.DemoTests; PRODUCT_NAME = "$(TARGET_NAME)"; @@ -569,6 +572,7 @@ BUNDLE_LOADER = "$(TEST_HOST)"; DEVELOPMENT_TEAM = XEV6645KTD; INFOPLIST_FILE = DemoTests/Info.plist; + IPHONEOS_DEPLOYMENT_TARGET = 12.0; LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; PRODUCT_BUNDLE_IDENTIFIER = com.takecian.DemoTests; PRODUCT_NAME = "$(TARGET_NAME)"; From 067429a1e1eaf612d89ff9b3b4d4ff17966aa21c Mon Sep 17 00:00:00 2001 From: Takeshi Fujiki Date: Thu, 4 Jul 2024 22:50:28 +0900 Subject: [PATCH 4/6] Support point argument --- Demo/Demo/ViewController.swift | 2 +- SwiftRater/SwiftRater.swift | 10 +++------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/Demo/Demo/ViewController.swift b/Demo/Demo/ViewController.swift index 85d17f9..56a2e28 100644 --- a/Demo/Demo/ViewController.swift +++ b/Demo/Demo/ViewController.swift @@ -13,7 +13,7 @@ class ViewController: UIViewController { override func viewDidAppear(_ animated: Bool) { super.viewDidAppear(animated) - SwiftRater.incrementSignificantUsageCount() + SwiftRater.incrementSignificantUsageCount(point: 1) SwiftRater.check(host: self) // If want to navigate app review page, use `rateApp()`. diff --git a/SwiftRater/SwiftRater.swift b/SwiftRater/SwiftRater.swift index 92fcd29..2a9d2fe 100644 --- a/SwiftRater/SwiftRater.swift +++ b/SwiftRater/SwiftRater.swift @@ -154,8 +154,8 @@ import StoreKit SwiftRater.shared.perform() } - @objc public static func incrementSignificantUsageCount() { - UsageDataManager.shared.incrementSignificantUseCount() + @objc public static func incrementSignificantUsageCount(point: Int = 1) { + UsageDataManager.shared.incrementSignificantUseCount(point: point) } #if os(iOS) @@ -324,11 +324,7 @@ import StoreKit private func incrementUsageCount() { UsageDataManager.shared.incrementUseCount() } - - private func incrementSignificantUseCount() { - UsageDataManager.shared.incrementSignificantUseCount() - } - + #if os(iOS) private func showRatingAlert(host: UIViewController?, force: Bool) { NSLog("[SwiftRater] Trying to show review request dialog.") From f4e4afbb2d19898146d4940b15babae592f5aa89 Mon Sep 17 00:00:00 2001 From: Takeshi Fujiki Date: Thu, 4 Jul 2024 22:58:58 +0900 Subject: [PATCH 5/6] Bump version --- SwiftRater.podspec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/SwiftRater.podspec b/SwiftRater.podspec index baa5a38..94d7342 100644 --- a/SwiftRater.podspec +++ b/SwiftRater.podspec @@ -8,9 +8,9 @@ Pod::Spec.new do |s| s.name = 'SwiftRater' - s.version = '2.1.2' + s.version = '2.1.3' s.summary = 'A utility that reminds your iPhone app users to review the app written in pure Swift.' - s.platform = :ios, '11.0' + s.platform = :ios, '12.0' # This description is used to generate tags and improve search results. # * Think: What does it do? Why did you write it? What is the focus? From 586961138af28ca5f4337746f6bf6f5a198a7848 Mon Sep 17 00:00:00 2001 From: Lee Seungjun | Celan <82270058+ValseLee@users.noreply.github.com> Date: Thu, 19 Sep 2024 15:28:53 +0900 Subject: [PATCH 6/6] Update README.md fix: dialong -> dialog typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e9d9240..111637a 100644 --- a/README.md +++ b/README.md @@ -114,7 +114,7 @@ You can set properties you want to apply. | :------------- |:-------------| | debugMode | Shows review request every time. Default false, **need to set false when you submit app to AppStore**. | | conditionsMetMode | Possible values: `.any`, `.all` (default)
Setting this to `.any` allows the prompt to be shown **when any one or more of your criteria have been met**. | -| showLaterButton | Show Later button in review request dialong, valid for iOS10.2 or before devices.| +| showLaterButton | Show Later button in review request dialog, valid for iOS10.2 or before devices.| | daysBeforeReminding | Days until reminder popup if the user chooses `rate later`, valid for iOS10.2 or before devices. | 2.Call `SwiftRater.check()` in `viewDidAppear` of ViewController where you want to show review request dialog. If conditions are met, SwiftRater will show review request popup.