From 44e8abdfcb289ed96b2de36e0d5add7d3778a528 Mon Sep 17 00:00:00 2001
From: Asumu Takikawa <asumu@igalia.com>
Date: Tue, 27 Jul 2021 17:48:52 -0700
Subject: [PATCH] [interpreter] adjust try_delegate semantics

Accounting for the discussion in

  https://github.com/WebAssembly/exception-handling/issues/176

adjust try_delegate so that it can target any block.
---
 interpreter/valid/valid.ml  | 10 +++++-----
 test/core/try_delegate.wast | 14 +++++++++-----
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/interpreter/valid/valid.ml b/interpreter/valid/valid.ml
index b68a2e0f2..f5ce3cf45 100644
--- a/interpreter/valid/valid.ml
+++ b/interpreter/valid/valid.ml
@@ -14,7 +14,7 @@ let require b at s = if not b then error at s
 
 (* Context *)
 
-type label_kind = BodyLabel | BlockLabel | TryLabel | CatchLabel
+type label_kind = BlockLabel | CatchLabel
 
 type context =
 {
@@ -409,7 +409,7 @@ let rec check_instr (c : context) (e : instr) (s : infer_stack_type) : op_type =
 
   | TryCatch (bt, es, cts, ca) ->
     let FuncType (ts1, ts2) as ft = check_block_type c bt in
-    let c_try = {c with labels = (TryLabel, ts2) :: c.labels} in
+    let c_try = {c with labels = (BlockLabel, ts2) :: c.labels} in
     let c_catch = {c with labels = (CatchLabel, ts2) :: c.labels} in
     check_block c_try es ft e.at;
     List.iter (fun ct -> check_catch ct c_catch ft e.at) cts;
@@ -419,8 +419,8 @@ let rec check_instr (c : context) (e : instr) (s : infer_stack_type) : op_type =
   | TryDelegate (bt, es, x) ->
     let FuncType (ts1, ts2) as ft = check_block_type c bt in
     let (kind, _) = label c x in
-    require (kind = TryLabel || kind = BodyLabel) e.at "invalid delegate label";
-    check_block {c with labels = (TryLabel, ts2) :: c.labels} es ft e.at;
+    require (kind = BlockLabel) e.at "invalid delegate label";
+    check_block {c with labels = (BlockLabel, ts2) :: c.labels} es ft e.at;
     ts1 --> ts2
 
   | Throw x ->
@@ -524,7 +524,7 @@ let check_type (t : type_) =
 let check_func (c : context) (f : func) =
   let {ftype; locals; body} = f.it in
   let FuncType (ts1, ts2) = type_ c ftype in
-  let c' = {c with locals = ts1 @ locals; results = ts2; labels = [(BodyLabel, ts2)]} in
+  let c' = {c with locals = ts1 @ locals; results = ts2; labels = [(BlockLabel, ts2)]} in
   check_block c' body (FuncType ([], ts2)) f.at
 
 let check_tag (c : context) (t : tag) =
diff --git a/test/core/try_delegate.wast b/test/core/try_delegate.wast
index a21f96c08..d6afe84be 100644
--- a/test/core/try_delegate.wast
+++ b/test/core/try_delegate.wast
@@ -45,6 +45,13 @@
     )
   )
 
+  (func (export "delegate-to-block") (result i32)
+    (try (result i32)
+      (do (block (try (do (throw $e0)) (delegate 0)))
+          (i32.const 0))
+      (catch_all (i32.const 1)))
+  )
+
   (func (export "delegate-to-caller")
     (try (do (try (do (throw $e0)) (delegate 1))) (catch_all))
   )
@@ -92,6 +99,8 @@
 
 (assert_return (invoke "delegate-skip") (i32.const 3))
 
+(assert_return (invoke "delegate-to-block") (i32.const 1))
+
 (assert_exception (invoke "delegate-to-caller"))
 
 (assert_malformed
@@ -118,8 +127,3 @@
   (module (func (try (do) (delegate 1))))
   "unknown label"
 )
-
-(assert_invalid
-  (module (func (block (try (do) (delegate 0)))))
-  "invalid delegate label"
-)