-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider setting panic to abort in teos #57
Comments
In the Cargo.toml file we can configure the program to abort on panic instead by adding: [profile.release]
panic = 'abort' I'm not familiar with the entire codebase so I'm not sure if this will cause any other issues, though if it does we probably want to handle those panics differently as well. Thoughts? I'd be happy to open a PR to fix this. |
@booklearner I'm pretty sure I tried that back in the day but it didn't work. You're more than welcome to give it a go though. |
Keeping an eye on this tokio-rs/tokio#4516 |
The
panic
behavior is set tounwind
at the moment (default), however, this means that if an async task fails, the daemon may not crash but the task will. This can set the daemon in a weird state where some things are expected to be running but they are not.An example to this is trying to run the daemon with tor support while the tor connection cannot be stablished:
We should consider changing the panic behavior or making this crash the daemon in some way.
Source: https://users.rust-lang.org/t/panic-in-tokio-task-does-not-end-the-program-execution/45731
The text was updated successfully, but these errors were encountered: