Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in CI #153

Open
2e0byo opened this issue Jul 10, 2023 · 4 comments
Open

Run tests in CI #153

2e0byo opened this issue Jul 10, 2023 · 4 comments
Assignees

Comments

@2e0byo
Copy link
Collaborator

2e0byo commented Jul 10, 2023

As something of a priority we need to fix the test suite, ideally before we merge anything else. I'll try to get on this this week, unless anyone else wants to.

Once it passes we should add vcr (pytest-recording) with sanitising and run it in ci.

FWIW I think 3.9 is probably broken, but we need tests running in ci to be confident.

@tehkillerbee
Copy link
Collaborator

tehkillerbee commented Jul 11, 2023

I agree. Feel free to take a look at it, as you are definitely the most qualified! ;)

@2e0byo
Copy link
Collaborator Author

2e0byo commented Jul 12, 2023

Tests now pass. We should run in vcr with pytest-recording, but for now lets not merge anything unless one of the maintainers has run the test suite locally.

I've not fixed tox as I don't like keeping the deps in two places, so poetry run pytest. Credentials will be cached locally.

@2e0byo
Copy link
Collaborator Author

2e0byo commented Jul 12, 2023

PS didn't add pytest-recording as it's currently broken. There's an open (abandoned) PR to work against latest VCR which would fix it; might pick that up if nobody else does.

@2e0byo
Copy link
Collaborator Author

2e0byo commented Aug 21, 2023

Most of the work to get tests running in ci is floating around in a branch on my fork. If someone has the time feel free to get it working: we need to mock the right properties on Session() (or modify it) so we can start a session up without the internet, but all the rest works as recorded. I'm not likely to have much time for this in the next few weeks, but I'll get on it if I can.

@2e0byo 2e0byo changed the title Fix test suite Run tests in CI Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants