Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test numbers and improve diff explanation. #29

Closed
tangentstorm opened this issue May 28, 2014 · 1 comment
Closed

remove test numbers and improve diff explanation. #29

tangentstorm opened this issue May 28, 2014 · 1 comment

Comments

@tangentstorm
Copy link
Contributor

Given the following learntris...

#!/usr/bin/env python
print('x')

We get:

Running test 1: io.q
q : quit
---- sending commands ----
q
---- awaiting results ----
: The 'q' command instructs learntris to quit.
:
: Learntris should not produce any output unless
: explicitly instructed to do so.
---- expected results ----

Test 1 failed: output mismatch:
- x

There are several cleanups that should be made:

  1. The lines Running test 1: io.q and Test 1 failed: output mismatch: should be modified so that both refer to the test name and neither refers to the number.
  2. There should be an explanation of the diff output.

Here is an example of how an improved version might look:

Running test: [io.q]
q : quit
+--- sending commands ----
q
+--- awaiting results ----
: The 'q' command instructs learntris to quit.
:
: Learntris should not produce any output unless
: explicitly instructed to do so.
+--- expected results ----
+--- output mismatch! ----
:
: Test [io.q] failed.
:
: The following diff show the changes required
: to pass the test.
:
:  '-' indicates a line to be removed,
:  '+' indicates a line to be added.
+-------------------------
- x
@tangentstorm
Copy link
Contributor Author

Fixed in #60 ... The diff explanation doesn't need to be in the output, but should still be in the docs. See #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant