Skip to content

Commit 990d260

Browse files
committed
minor cleanup
1 parent 5f35627 commit 990d260

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/scene/globals.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ const GLOBAL_REGISTRY = '__global_prop';
1010

1111
// Property name references a global property?
1212
export function isGlobalReference (val) {
13-
if (val && val.slice(0, GLOBAL_PREFIX_LENGTH) === GLOBAL_PREFIX) {
14-
return true;
15-
}
16-
return false;
13+
return val?.slice(0, GLOBAL_PREFIX_LENGTH) === GLOBAL_PREFIX;
1714
}
1815

1916
// Has object property been substitued with a value from a global reference?

src/scene/scene_loader.js

-1
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,6 @@ const SceneLoader = {
281281
if (typeof curValue === 'string' && config.textures[curValue] == null) {
282282
if (isGlobalSubstitution(config, path)) {
283283
// global substituions are resolved against the base scene path, not the import they came from
284-
// const url = curValue;
285284
const url = base_bundle.urlFor(curValue);
286285
config.textures[curValue] = { url };
287286
}

0 commit comments

Comments
 (0)