-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
code healthImprove code readability, simplify maintenance and so onImprove code readability, simplify maintenance and so on
Description
Strconv allows to call ParseUint for 32bit number instead of 64bit with third argument so it would be later converted to 32bit number:
cartridge-cli/cli/common/tarantool.go
Line 67 in 479a592
res, err := strconv.ParseUint(str, 10, 32) |
Since we use uint64 everywhere, it should be replaced with
(str, 10, 64)
. Or numbers should be transformed to uint32 since version numbers are not likely to be greater than max uint32.Metadata
Metadata
Assignees
Labels
code healthImprove code readability, simplify maintenance and so onImprove code readability, simplify maintenance and so on