Skip to content

Change token type to SecretStr in Settings #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
colindean wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Change token type to SecretStr in Settings #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b5698c
Change token type to SecretStr in Settings
colindean Jan 27, 2026
50e6072
Add SecretStr import to settings.py
colindean Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions diff_poetry_lock/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from typing import Any, ClassVar, Protocol, runtime_checkable

from loguru import logger
from pydantic import BaseSettings, Field, PrivateAttr, ValidationError, validator
from pydantic import BaseSettings, Field, PrivateAttr, SecretStr, ValidationError, validator


class PrLookupService(Protocol):
Expand Down Expand Up @@ -53,7 +53,7 @@ class VelaSettings(BaseSettings, Settings):
repo_branch: str = Field(env="VELA_REPO_BRANCH")

# from step config including secrets
token: str = Field(env="PARAMETER_GITHUB_TOKEN")
token: SecretStr = Field(env="PARAMETER_GITHUB_TOKEN")
lockfile_path: str = Field(env="PARAMETER_LOCKFILE_PATH", default="poetry.lock")
api_url: str = Field(env="PARAMETER_GITHUB_API_URL", default="https://api.github.com")

Expand Down Expand Up @@ -97,7 +97,7 @@ class GitHubActionsSettings(BaseSettings, Settings):
base_ref: str = Field(env="github_base_ref")

# from step config including secrets
token: str = Field(env="input_github_token")
token: SecretStr = Field(env="input_github_token")
lockfile_path: str = Field(env="input_lockfile_path", default="poetry.lock")
api_url: str = Field(env="github_api_url", default="https://api.github.com")

Expand Down
Loading