Skip to content

ocaml-eglot-find-definition lacks a way to come back? #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ttamttam opened this issue Mar 16, 2025 · 4 comments
Open

ocaml-eglot-find-definition lacks a way to come back? #36

ttamttam opened this issue Mar 16, 2025 · 4 comments

Comments

@ttamttam
Copy link

Maybe I did not found the way to do it?

When using merlin, after C-c C-l, I can go back with C-c C-; (merlin-pop-stack, I think).

Is there something similar (already or planned)?

Best regards

@ttamttam
Copy link
Author

Oh. xref-find-* and xref-go-back are working fine.

Sorry for the noise.

@xvw
Copy link
Member

xvw commented Mar 17, 2025

Thanks for your ticket!
Anyway, I think it might be worth having commands prefixed with ocaml-eglot- to standardize command calls. So I'll keep the issue open!

@bbatsov
Copy link
Contributor

bbatsov commented Mar 27, 2025

I don't think that'd be needed, as xref is a pretty common API in Emacs and packages are just supposed to integrate with it. But I'm guessing it won't hurt to mention those commands in the mode menu, or in the docs, as people not very familiar with Emacs might not know that at all.

@tmcgilchrist
Copy link
Contributor

It would be more useful to emphasise in the documentation how many of the standard eglot and xref bindings work with ocaml-eglot rather than introducing new keybindings. The appeal of using LSP and eglot is how common things are between languages that support LSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants