Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a message about unsatisfiable constraints #260

Open
NathanReb opened this issue Feb 18, 2022 · 0 comments
Open

Add a message about unsatisfiable constraints #260

NathanReb opened this issue Feb 18, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers solver-errors For all solver error related issues and features upstream Fix has to be implemented upstream
Milestone

Comments

@NathanReb
Copy link
Contributor

We recently introduced messages upon solver failure to warn the users that the solver couldn't find a solution because some packages don't build with dune, listing those packages.

This is great because it is both very clear and actionable for the user, even though writing a dune port won't always be very appealing to users.

In the same fashion we introduced a message that woud disambiguate that even though a package had no dune building version, the main reason why it got rejected is because it had no existing version that match the constraints.

It would be nice to have a generic version of that last message because, similar to the dune thing, it is very clear then why the solver finds no solution and is in most cases very actionable: the user wrote the wrong constraint somewhere or forgot to add a repository or to update one.

To sum up it would be nice if upon failure to find a solution to the dependency specification, we listed the packages that have no satisfying versions available and the packages that have but don't build with dune at all.

@NathanReb NathanReb added the solver-errors For all solver error related issues and features label Feb 18, 2022
@NathanReb NathanReb added this to the 0.3.1 milestone Apr 15, 2022
@tmattio tmattio added enhancement New feature or request good first issue Good for newcomers upstream Fix has to be implemented upstream labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers solver-errors For all solver error related issues and features upstream Fix has to be implemented upstream
Projects
None yet
Development

No branches or pull requests

2 participants