Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial changes to install opam-monorepo and use it to pull dependencies #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leonidas-from-XIV
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV commented Jun 24, 2022

To get things rolling I started writing the simplest thing that could possibly work, a branch that only supports building via opam-monorepo thus can only build the opam-monorepo Tezos branch.

The question is: how do we proceed from here?

  • Can we somehow get this deployed on a separate cluster and work from there?
  • How can we test this?
  • Should we somehow integrate it to support both builds (the mid-term plan is to get Tezos to use opam-monorepo anyway, so is there even a point in having support for both?)
  • How does Tezos want their Docker containers to be laid out?

Anyway, I find it easier to discuss over actual code, so here's a proposal. cc @NathanReb @tmcgilchrist @tmattio

Fixes #54

@NathanReb
Copy link

I think this needs an extra opam install --deps-only --ignore-pin-depends ./<path-to-lockfile>!

@NathanReb
Copy link

Also, if I understand this correctly, we'd need to move those commands before copying the sources and after a new copy that would get the lock file so that it will only be invalidated by a change in the lock file, not in the rest of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate adding opam-monorepo support for Octez pipeline
2 participants