Add rule to avoid destructuring in params

[lxcid]

I personally think this rule is prone to error.

When we do destructuring params, it usually meant for options or props.

And we sometimes also provide default params to them, especially options: e.g.

function foo({ bar = true } = {}) {
}

This mean that if the first argument to foo is undefined, assign it to {} and we then destructure the attribute bar which if undefined, it defaults to true.

First, there is way too much logic going on for just something as simple. Secondly, null will break the assumption pretty badly. e.g. if we pass null as first argument, it will crash. or if we pass null to bar, it will not default to true and take on null value. Although such cases can be now caught in the TypeScript land easily.

I would have prefer the following code

function foo(options) {
  const bar = options?.foo ?? true;
}

This will cover all possible null and undefined cases as mentioned above. much more clear and easily to follow with no special object created implicitly thus actually more performant.

Copy in the rule from here…

https://github.com/lukeapage/eslint-plugin-destructuring