You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
code contains some code that could be more compartmentalized into a function for easier readability. The err variable is reassigned often and can be challenging to track
eg. lines 96-108
func TestKillService(t *testing.T) {
err := universe.KillService("seer")
if err != nil { // should not fail
t.Errorf("Failed kill call with error: %v", err)
} else { // should fail
err = universe.KillService("seer")
if err == nil {
t.Error("Expected killing seer again to fail")
}
}
}
lines 73-94 could also be compartmentalized.
The text was updated successfully, but these errors were encountered:
service/universe_test.go
code contains some code that could be more compartmentalized into a function for easier readability. The err variable is reassigned often and can be challenging to track
eg. lines 96-108
lines 73-94 could also be compartmentalized.
The text was updated successfully, but these errors were encountered: