Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update email_account resource to connected_account #63

Open
AlecRosenbaum opened this issue Oct 16, 2020 · 5 comments · May be fixed by #83
Open

Update email_account resource to connected_account #63

AlecRosenbaum opened this issue Oct 16, 2020 · 5 comments · May be fixed by #83

Comments

@AlecRosenbaum
Copy link

Hi!

I noticed that this gem has a resource for accessing email_account on the api, and I can also see some traffic on that endpoint from this gem. Would it be possible to update or replace the resource to hit connected_account instead?

I'm not sure if email_account was documented at one point, but internally we've been moving away from it in favor of connected_account for some time now. The connected account endpoint should be better documented, and will be better supported going forward!

I'm not very experienced with ruby, but if it's as simple as s/email/connected/g within the ruby code I can submit a patch.
@AlecRosenbaum AlecRosenbaum changed the title Updated email_account resource to connected_account Update email_account resource to connected_account Oct 16, 2020
@taylorbrooks
Copy link
Owner

@AlecRosenbaum Is the response structure the same?

@squeaky-pl
Copy link

@taylorbrooks Yes, you get exactly the same fields you would get from email_account. We are planning on deprecating and removing email_account soon as most of our customers migrated away from it.

@neob91-close
Copy link

@taylorbrooks We'd really appreciate any help you can give us to push this forward.

@taylorbrooks
Copy link
Owner

@neob91-close I'm happy to accept PRs!

@neob91-close neob91-close linked a pull request Jan 16, 2025 that will close this issue
Open
@neob91-close
Copy link

Opened a PR: #83.

I have 0 experience with Ruby though, so I could really use your help in making sure that the change works okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from /api/v1/email_account/ to /api/v1/connected_account/ neob91-close/closeio-ruby-client
4 participants
@taylorbrooks @squeaky-pl @AlecRosenbaum @neob91-close