Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow app to close yet leave batch process running #6

Open
tballison opened this issue Oct 5, 2022 · 3 comments
Open

Allow app to close yet leave batch process running #6

tballison opened this issue Oct 5, 2022 · 3 comments
Milestone

Comments

@tballison
Copy link
Owner

This will also allow the app to open up and see if the last started process is still running.

Will need to ensure that the app can only kick off one batch process at a a time.

@tballison
Copy link
Owner Author

This basically works now. Still need to add the check mentioned above, and we still need to add confirmation that the process id that is stored in the state.json file is actually the same batch process once the app is turned back on and looks up that process id. That is, we don't want this application to accidentally kill a process that happens to have the old process id's id. The chances of this are really small, but we should add some checks.

@tballison
Copy link
Owner Author

Will likely turn this off in the near term because of the complexity it adds to the code.

@tballison tballison modified the milestones: 1.1.0, v1.1.0, v1.2.0 Oct 27, 2022
@tballison
Copy link
Owner Author

I've thoroughly disabled this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant