-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailer method in Title class is broken #328
Comments
Well.. imdb changed the trailer page, so this is to be expected. if anyone is interested in fixing this the right way here is the query i use:
Figure out the rest yourself as it works the same as other GraphQL methods. My trailer method is different but you can look at it as a reference As a courtesy to show that i DO care and respect this project and maintainers. And if anyone wonders why this is in my method: |
Thanks @duck7000, I actually already implemented your graphql method in my own fork. Just took out the get_headers() check which takes forever on my environnement, don't know why. |
Get_headers will check if the found url can be used as embedded url in an iframe, not all urls are allowed to do so. It wonders me though why you add this issue here but use your own fork? |
Well, because I'm not a developper, and true developpers do a better work than me :) |
I'm not a true developer either hah |
Just tested with "2001, a space odyssey".
No trailer is found, despite there are many:
https://www.imdb.com/title/tt0062622/videogallery/content_type-trailer
The text was updated successfully, but these errors were encountered: