Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of "The order in which module records have their [[AsyncEvaluation]] fields transition to true is significant" #3289

Open
bakkot opened this issue Feb 28, 2024 · 1 comment · May be fixed by #3353

Comments

@bakkot
Copy link
Contributor

bakkot commented Feb 28, 2024

AsyncModuleExecutionFulfilled sorts a list according to "the order in which [the elements] had their [[AsyncEvaluation]] fields set to true".

That's pretty wild: it implies you need to keep track of not just the current state of the spec's data structures, but the order in which they changed. We should get rid of that.

The simplest fix would be to have a global integer which is incremented every time we use it, and store that in the field instead of the boolean.

@syg
Copy link
Contributor

syg commented Feb 28, 2024

Indeed, the global integer (modulo some overflow handling complexity that's not needed in the spec) is how V8 implements that logic anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants