Normative: Add Locale.prototype.getVariants #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
added
enhancement
needs tests
c: locale
FrankYFTang
reviewed
Mar 6, 2025
| 1. Perform ? RequireInternalSlot(_loc_, [[InitializedLocale]]). | ||
| 1. Let _variantsString_ be GetLocaleVariants(_loc_.[[Locale]]). | ||
| 1. Let _variantsList_ be StringSplitToList(_variantsString_, *"-"*). | ||
| 1. Return CreateArrayFromList(_variantsList_). |
There was a problem hiding this comment.
- @anba Should this also state the order need to be in alphabetical order ?
See the order discussion in
https://unicode.org/reports/tr35/#Canonical_Unicode_Locale_Identifiers
There was a problem hiding this comment.
It might benefit from a note, but nothing more—alphabetization is already required by use of CanonicalizeUnicodeLocaleId in the Intl.Locale constructor.
|
If we do this, then how about setting variants in option bag them? |
Good question, and I think the answer is "yes". This also interacts with the design question about representing variants as an array of strings or as a single dash-separated string, and I'm increasingly inclined towards the latter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #900
I was reminded of this by tc39/test262#4394.