Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return exit code zero on success #377

Closed
codefromthecrypt opened this issue Nov 20, 2024 · 2 comments
Closed

return exit code zero on success #377

codefromthecrypt opened this issue Nov 20, 2024 · 2 comments

Comments

@codefromthecrypt
Copy link

I have found markdown-link-check returning exit code 1 on files that pass link checks. I noticed in another project, people doing markdown-link-check ... || true to avoid this.

However, I would like to have exit code 1 when there is a real failure. Is this a bug?

$ markdown-link-check -V
3.13.6

$ markdown-link-check -v -c ./build-bin/mlc_config.json ./zipkin-junit5/README.md

FILE: ./zipkin-junit5/README.md

$ echo $?
1
@isuftin
Copy link

isuftin commented Nov 20, 2024

@codefromthecrypt - I think your issue is due to md link check 3.13.x is broken when using a config file - See #369

@codefromthecrypt
Copy link
Author

@isuftin indeed thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants