Skip to content
This repository has been archived by the owner on Dec 10, 2022. It is now read-only.

Pokemon emojis not loaded on playslackemon.slack.com #36

Open
juz501 opened this issue Jun 18, 2017 · 6 comments
Open

Pokemon emojis not loaded on playslackemon.slack.com #36

juz501 opened this issue Jun 18, 2017 · 6 comments
Assignees
Labels

Comments

@juz501
Copy link
Collaborator

juz501 commented Jun 18, 2017

Should load the emojis

@juz501 juz501 added the bug label Jun 18, 2017
@juz501
Copy link
Collaborator Author

juz501 commented Jun 18, 2017

for the pokemon btw.. the elemental ones work

@tdmalone
Copy link
Owner

tdmalone commented Jun 18, 2017

Yeah I know, I haven't got to that yet :P

I've made you an admin of the Slack team if you want to have a crack at it, otherwise I will get to it later on.

We need to add the steps as we go to the README here (point 9 under Setup).

Here are the tools I used last time (I think - there's a few out there that do it):
https://github.com/Templarian/slack-emoji-pokemon
https://github.com/lambtron/emojipacks

@tdmalone tdmalone changed the title playslackemon emojis not loaded Pokemon eojis not loaded on playslackemon.slack.com Jun 18, 2017
@Naramsim Naramsim changed the title Pokemon eojis not loaded on playslackemon.slack.com Pokemon emojis not loaded on playslackemon.slack.com Jun 20, 2017
@tdmalone
Copy link
Owner

tdmalone commented Jun 21, 2017

Also missing:

:party_parrot:
:fingers_crossed:

EDIT: These two are now done. Pokemon are not done yet.

@tdmalone tdmalone self-assigned this Jun 22, 2017
@tdmalone
Copy link
Owner

tdmalone commented Jun 22, 2017

I've started on the Pokemon emoji in 5de12f6.
Most of that was automated based on an ls in the pokecss-media repo and some Sublime wrangling, but it needs some manual fixing for the files that have hyphens in them.
I'm up to B H so far :P DONE

This should then work with https://github.com/lambtron/emojipacks but I'll test it with a small subset first to make sure the images are the right size for Slack (EDIT - it works).

If all works I will update the README here and also notify https://github.com/Templarian/slack-emoji-pokemon that I've put this together, as they only have Gen I and sort of Gen II there at the moment.

@tdmalone
Copy link
Owner

tdmalone commented Jun 22, 2017

Most emoji are now uploaded to playslackemon.slack.com.

Some didn't work - I need to look into why; probably the filesizes or dimensions are too big to use some for emoji; we might need to source alternatives or otherwise edit them down.

EDIT - Yes, anything with a dimension over 128px will fail.

Pokemon I've caught in Slackemon that didn't work:

  • Exeggutor
  • Aerodactyl
  • Articuno
  • Lugia
  • Ho Oh
  • Wingull
  • Tropius
  • Kyogre
  • Honchkrow

There may be more (probably is, especially Gen IV onwards).

  • TODO: Add the type icons to the emoji pack. DONE

This is all being tracked on the emoji branch.

tdmalone added a commit that referenced this issue Jun 22, 2017
* emoji:
  Add type emoji to emojipack yaml + minor readme update
  Add type emoji
  #36: Continue emoji YAML, H-Z, + update readme
  Update a bunch of out-dated media URLs
  Replace all emoji URLs with commit hashes so we don't have to keep them up-to-date
  Include bundled emoji in emojipack file
  #36: WIP: Continue emoji YAML file organising, B-G
  WIP: Put together a YAML file that can be used by emojipacks
@tdmalone
Copy link
Owner

All of the above updates are now in master as of v0.0.41.

Still needs above 128px images fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants