fix: filter empty text (#1942)

* fix: empty string should be empty when filter

* fix: should not call the database connection api without permission

Author: caoxing9

apps/nestjs-backend/src/db-provider/filter-query/cell-value-filter.abstract.ts

@@ -216,7 +216,20 @@ export abstract class AbstractCellValueFilter implements ICellValueFilterInterfa
     _operator: IFilterOperator,
     _value: IFilterValue
   ): Knex.QueryBuilder {
-    builderClient.whereNull(this.tableColumnRef);
+    const tableColumnRef = this.tableColumnRef;
+    const { cellValueType, isStructuredCellValue, isMultipleCellValue } = this.field;
+
+    builderClient.where(function () {
+      this.whereNull(tableColumnRef);
+
+      if (
+        cellValueType === CellValueType.String &&
+        !isStructuredCellValue &&
+        !isMultipleCellValue
+      ) {
+        this.orWhere(tableColumnRef, '=', '');
+      }
+    });
     return builderClient;
   }
 
@@ -225,7 +238,13 @@ export abstract class AbstractCellValueFilter implements ICellValueFilterInterfa
     _operator: IFilterOperator,
     _value: IFilterValue
   ): Knex.QueryBuilder {
+    const { cellValueType, isStructuredCellValue, isMultipleCellValue } = this.field;
+
     builderClient.whereNotNull(this.tableColumnRef);
+
+    if (cellValueType === CellValueType.String && !isStructuredCellValue && !isMultipleCellValue) {
+      builderClient.where(this.tableColumnRef, '!=', '');
+    }
     return builderClient;
   }
 

apps/nestjs-backend/test/data-helpers/20x.ts

@@ -135,7 +135,9 @@ export const x_20 = {
   // actual number of items: 23
   records: [
     {
-      fields: {},
+      fields: {
+        [textField.name]: '',
+      },
     },
     {
       fields: {

apps/nextjs-app/src/features/app/blocks/db-connection/hooks/useDbConnection.ts

@@ -1,13 +1,21 @@
 import { useQuery } from '@tanstack/react-query';
-import { getDbConnection } from '@teable/openapi';
-import { useBaseId } from '@teable/sdk/hooks';
+import { BillingProductLevel, getDbConnection } from '@teable/openapi';
+import { useBaseId, useBasePermission } from '@teable/sdk/hooks';
+import { useBaseUsage } from '@/features/app/hooks/useBaseUsage';
+import { useIsCloud } from '@/features/app/hooks/useIsCloud';
 
 export const useDbConnection = () => {
   const baseId = useBaseId() as string;
+  const permissions = useBasePermission();
+  const hasPermission = permissions?.['base|db_connection'];
+  const isCloud = useIsCloud();
+  const usage = useBaseUsage();
+  const isUnavailable = isCloud && usage?.level !== BillingProductLevel.Enterprise;
 
   const { data, isLoading } = useQuery({
     queryKey: ['connection', baseId],
     queryFn: ({ queryKey }) => getDbConnection(queryKey[1]).then((data) => data.data),
+    enabled: hasPermission && !isUnavailable,
   });
 
   const dataArray = data?.dsn