Open
Conversation
…ver 2025 formatting and TODOs
rwlee
requested review from
AustinSchuh,
alisonsoong and
anika-kum
and removed request for
alisonsoong
anika-kum
approved these changes
Feb 9, 2026
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Tagalong CANBus manager instance manager, only CTRE devices are currently registered or supported |
Collaborator
There was a problem hiding this comment.
Tagalong CANBus instance manager
| /** | ||
| * Map of all instances with a CTRE device registered to them | ||
| */ | ||
| private static final Map<String, CANBus> _ctreCANBus = Map.of(); |
Collaborator
There was a problem hiding this comment.
Using Map.of() with no parameters creates an UnsupportedOperationException when we try to put stuff in it on line 25
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Map.html#unmodifiable
private static final Map<String, CANBus> _ctreCANBus = new HashMap<>()
| table.put("ElevatorAppliedVolts", elevatorAppliedVolts); | ||
| table.put("ElevatorCurrentAmps", elevatorCurrentAmps); | ||
| table.put("ElevatorHeightM", elevatorHeightM, "meters"); | ||
| table.put("ElevatorVelocityMPS", elevatorVelocityMPS, "meters/second"); |
| table.put("PivotAppliedVolts", pivotAppliedVolts); | ||
| table.put("PivotCurrentAmps", pivotCurrentAmps); | ||
| table.put("PivotPositionRot", pivotPositionRot, "rotations"); | ||
| table.put("PivotVelocityRPS", pivotVelocityRPS, "rotations/second"); |
| table.put("RollerAppliedVolts", rollerAppliedVolts); | ||
| table.put("RollerCurrentAmps", rollerCurrentAmps); | ||
| table.put("RollerPositionRot", rollerPositionRot, "rotations"); | ||
| table.put("RollerVelocityRPS", rollerVelocityRPS, "rotations/second"); |
| > `(WPILibVersion in format YYYY.MajorMinor).MMDD` | ||
|
|
||
| For example, a TagalongLib release on January 1st, 2025 using WPILib version 2024.1.0 would be version `2025.10.0101`. | ||
| For example, a TagalongLib release on January 1st, 2026 using WPILib version 2024.1.0 would be version `2026.10.0101`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably should have split this up into a copyright PR and other PR, oops
Bump copyright year, adapt to some 2026 library changes (namely CANBus conventions in phoenix 6), fix some leftover 2025 formatting and TODOs
TODO: add advantage scope CANBus logging