Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder should also support password callback #28

Open
Cryptophobia opened this issue Mar 21, 2018 · 1 comment
Open

builder should also support password callback #28

Cryptophobia opened this issue Mar 21, 2018 · 1 comment

Comments

@Cryptophobia
Copy link
Member

From @smothiki on May 11, 2016 22:57

Right now we are just using password callback in tests, it would be nice to support password call back , keeping in mind stand alone builder work.

Copied from original issue: deis/builder#331

@Cryptophobia
Copy link
Member Author

From @bacongobbler on October 31, 2016 20:11

I don't think this is something we want to allow. In a multi-tenant environment everyone should not have access to the git user's password, as there is no way we can authenticate who is pushing the build in the controller.

Keeping this open for discussion but I believe we should only allow keys. Much easier to allow/reject than changing a global password on a public PaaS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant