Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for Dart-Sass 2.0 - use of '/' for division #66

Open
astilla opened this issue Jul 7, 2021 · 0 comments
Open

Deprecation warning for Dart-Sass 2.0 - use of '/' for division #66

astilla opened this issue Jul 7, 2021 · 0 comments

Comments

@astilla
Copy link
Member

astilla commented Jul 7, 2021

Just a reminder for now as TADC is now using dart-sass (as node-sass is deprecated) but this library still uses node-sass to compile the the distribution.

If anything uses the SCSS files here and compiles them manually with dart-sass they'll get these warnings:

     [exec]    ???
     [exec] 56 ???   margin-top: ($line-height-computed / 2);
     [exec]    ???                ^^^^^^^^^^^^^^^^^^^^^^^^^
     [exec]    ???
     [exec]     www/bower/bootstrap-sass/assets/stylesheets/bootstrap/_type.scss 56:16  @import
     [exec]     www/bower/bootstrap-sass/assets/stylesheets/_bootstrap.scss 16:9        @import
     [exec]     www/bower/bootstrap-sass/app.scss 3:9                                   @use
     [exec]     sass/bundle-css.scss 1:1                                                root stylesheet
     [exec] 
     [exec] DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
     [exec] 
     [exec] Recommendation: math.div($line-height-computed, 2)
     [exec] 
     [exec] More info and automated migrator: https://sass-lang.com/d/slash-div

It mentions how to fix them above with math.div(...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant