Skip to content

Commit

Permalink
Merge pull request #1 from talis/travis-ci-build
Browse files Browse the repository at this point in the history
90%: Move to Travis CI build
  • Loading branch information
pads committed Jan 9, 2016
2 parents d791bd3 + 0d0cdfb commit d2f60fa
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 18 deletions.
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
4.2
8 changes: 8 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
language: node_js
node_js:
- stable
before_script:
- npm install -g gulp
- "export DISPLAY=:99.0"
- "sh -e /etc/init.d/xvfb start"
- sleep 3
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
files and running a development server. You'll need to run ```npm install``` in order to install the development
dependencies and ```npm install -g gulp``` in order to install [gulp](http://gulpjs.com). The development server should
be available at [http://localhost:8080/](http://localhost:8080/).
3. Increment the version number in package.json, bower.json, and src/ng-context-menu.js
5. Create pull requests on the **development** branch not master!
4. Run ```gulp test``` to execute browser tests, this requires Firefox is installed and available in your PATH.
5. Increment the version number in package.json, bower.json, and src/ng-context-menu.js
6. Create pull requests on the **development** branch not master!

Thank you for your contribution!

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ for their contributions.

---

[![Code Climate](https://codeclimate.com/github/ianwalter/ng-context-menu.png)](https://codeclimate.com/github/ianwalter/ng-context-menu) [![Circle CI](https://circleci.com/gh/ianwalter/ng-context-menu.svg?style=svg)](https://circleci.com/gh/ianwalter/ng-context-menu)
[![Code Climate](https://codeclimate.com/github/ianwalter/ng-context-menu.png)](https://codeclimate.com/github/ianwalter/ng-context-menu) [![Build Status](https://travis-ci.org/talis/ng-context-menu.svg)](https://travis-ci.org/talis/ng-context-menu)

---

Expand Down
5 changes: 0 additions & 5 deletions circle.yml

This file was deleted.

6 changes: 3 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ gulp.task('protractor', function(done) {
configFile: 'protractor.conf.js',
args: [
'--baseUrl', 'http://127.0.0.1:' + program.port,
'--browser', program.browsers ? program.browsers[0] : 'chrome'
'--browser', program.browsers ? program.browsers[0] : 'firefox'
]
}))
.on('end', function() {
Expand Down Expand Up @@ -114,6 +114,6 @@ function watch() {
jsWatcher.on('change', changeNotification);
}

gulp.task('default', ['watch-mode', 'js', 'lint', 'test'], watch);
gulp.task('default', ['watch-mode', 'js', 'lint', 'protractor-install'], watch);
gulp.task('server', ['connect', 'default']);
gulp.task('test', ['connect', 'protractor-install', 'protractor']);
gulp.task('test', ['connect', 'protractor']);
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "index.html",
"devDependencies": {
"commander": "^2.3.0",
"gulp": "~3.5.1",
"gulp": "~3.9.0",
"gulp-concat": "~2.1.7",
"gulp-connect": "^2.0.5",
"gulp-jshint": "~1.3.4",
Expand All @@ -16,6 +16,7 @@
"protractor": "^1.2.0"
},
"scripts": {
"pretest": "gulp protractor-install",
"test": "gulp test"
},
"keywords": [
Expand Down
8 changes: 2 additions & 6 deletions protractor.conf.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var outputDir = process.env.CIRCLE_TEST_REPORTS || 'test-result';
var outputDir = 'test-result';
var config = {
capabilities: {
browserName: 'chrome'
browserName: 'firefox'
},
onPrepare: function() {
require('jasmine-reporters');
Expand All @@ -12,8 +12,4 @@ var config = {
specs: ['test/ui/**/*.spec.js']
};

if (process.env.CI) {
config.seleniumAddress = 'http://localhost:4444/wd/hub';
}

exports.config = config;

0 comments on commit d2f60fa

Please sign in to comment.