Skip to content

Commit c36b11e

Browse files
committed
Updates from PR comments
1 parent 1c606ae commit c36b11e

File tree

4 files changed

+129
-126
lines changed

4 files changed

+129
-126
lines changed

src/mongo/delegates/Views.class.php

+6
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,12 @@ public function findImpactedComposites(Array $resourcesAndPredicates, $contextAl
7474
{
7575
$resources = array_keys($resourcesAndPredicates);
7676

77+
// This should never happen, but in the event that we have been passed an empty array or something
78+
if(empty($resources))
79+
{
80+
return array();
81+
}
82+
7783
$contextAlias = $this->getContextAlias($contextAlias); // belt and braces
7884

7985
// build a filter - will be used for impactIndex detection and finding direct views to re-gen

test/rest-interface/composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
"minimum-stability": "dev",
99
"require": {
1010
"slim/slim": "2.*",
11-
"talis/tripod-php" : "dev-allow-multiple-queues"
11+
"talis/tripod-php" : "*"
1212
}
1313
}

test/unit/mongo/MongoTripodDriverTest.php

+1-3
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ public function testSaveChangesWithInvalidCardinality()
848848
}
849849

850850

851-
public function testDiscoverImpactedSubjectsAreDoneAllOperationsSync()
851+
public function testDiscoverImpactedSubjectsAreDoneAllOperationsASync()
852852
{
853853
$uri_1 = "http://example.com/1";
854854
$uri_2 = "http://example.com/2";
@@ -1158,7 +1158,6 @@ public function testDiscoverImpactedSubjectsForDefaultOperationsSetting()
11581158
// a delete and an update
11591159
$nG = new \Tripod\Mongo\MongoGraph();
11601160
$nG->add_graph($oG);
1161-
// This should
11621161
$nG->add_literal_triple($uri_1, $nG->qname_to_uri("searchterms:title"), "wibble");
11631162
$nG->remove_resource_triple($uri_2, $oG->qname_to_uri("rdf:type"), "http://foo/bar#Class2");
11641163

@@ -1305,7 +1304,6 @@ public function testSpecifyQueueForAsyncOperations()
13051304
// a delete and an update
13061305
$nG = new \Tripod\Mongo\MongoGraph();
13071306
$nG->add_graph($oG);
1308-
// This should
13091307
$nG->add_literal_triple($uri_1, $nG->qname_to_uri("searchterms:title"), "wibble");
13101308
$nG->remove_resource_triple($uri_2, $oG->qname_to_uri("rdf:type"), "http://foo/bar#Class2");
13111309

0 commit comments

Comments
 (0)